github: Grant actions: write
permission
#1580
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered by @sarahethompson the new v4 version of the action we use now requires this permission.
Not providing the permission leads to those artifacts to not be deleted, which in turn trips up other workflows related to CRT which then attempt to upload these artifacts just because they are in the same path. CRT does not currently have path allowlist to ignore such artifacts but there is an internal feature request.
This is surfaced as the following error:
In retrospect it does make sense that in order to delete an artifact, one needs write permission of some kind. It is puzzling that this behaviour (requirement of permissions) is dependent on versions.
https://github.com/GeekyEggo/delete-artifact?tab=readme-ov-file#-usage