Treat schema availability as not essential #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does *not* yet introduce support for more complex hierarchies but enables formatting even for files in directories which do not have any plugin cache. The lack of plugin cache is now emitted just as a log message. Informing the user at this point wouldn't be very helpful because we don't know where the module usually gets init'd from yet, i.e. whether the plugin cache is even expected *there*.
paultyng
approved these changes
Jun 19, 2020
| @@ -78,15 +78,15 @@ func (rmm *rootModuleManager) AddRootModule(dir string) error { | |||
|
|
|||
| _, exists := rmm.rms[dir] | |||
| if exists { | |||
| return fmt.Errorf("rootModule %s was already added", dir) | |||
| return fmt.Errorf("root module %s was already added", dir) | |||
There was a problem hiding this comment.
Not sure if it matters, but should this just be a noop instead of an error?
There was a problem hiding this comment.
I suppose it may come down to it eventually, but I think we do not ever add the same module twice, and if we are then I'd like to understand why first, before allowing it.
This was referenced Jun 20, 2020
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #83
This does not yet introduce support for more complex hierarchies
but enables formatting even for files in directories
which do not have any plugin cache.
The lack of plugin cache is now emitted just as a log message.
Informing the user at this point wouldn't be very helpful
because we don't know where the module usually gets init'd from yet,
i.e. whether the plugin cache is even expected there.
Complex hierarchies will be addressed in other PRs in iterative steps as part of #32