Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform/rootmodule: Make walker async by default #196

Merged
merged 1 commit into from
Jul 3, 2020
Merged

terraform/rootmodule: Make walker async by default #196

merged 1 commit into from
Jul 3, 2020

Conversation

radeksimko
Copy link
Member

Closes #188

There is some more work needed around cancellation (some tech debt is now a little more exposed as a result of this PR 😄 ), but that's resolvable separately as part of #195

@radeksimko radeksimko added the enhancement New feature or request label Jun 30, 2020
@radeksimko radeksimko requested a review from paultyng June 30, 2020 18:43
@radeksimko radeksimko force-pushed the f-async-walker branch 2 times, most recently from 0f69fe9 to 2ba6888 Compare July 1, 2020 13:49
@radeksimko radeksimko mentioned this pull request Jul 1, 2020
Merged
paultyng
paultyng approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@paultyng paultyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, you may want to add -race to your ci testing, not sure how much time it will add, but worth investigating probably.

@radeksimko radeksimko added this to the v0.5.0 milestone Jul 3, 2020
@radeksimko radeksimko added bug Something isn't working and removed enhancement New feature or request labels Jul 3, 2020
@radeksimko radeksimko modified the milestones: v0.5.0, v0.4.2 Jul 3, 2020
@radeksimko radeksimko mentioned this pull request Jul 3, 2020
Closed
@radeksimko
Copy link
Member Author

Agreed about -race, I have opened #206

@radeksimko radeksimko merged commit 723d8d3 into master Jul 3, 2020
@radeksimko radeksimko deleted the f-async-walker branch July 3, 2020 14:27
@radeksimko radeksimko mentioned this pull request Jul 9, 2020
Closed
@radeksimko radeksimko modified the milestones: v0.4.2, v0.5.0 Jul 10, 2020
@ghost
Copy link

ghost commented Aug 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Aug 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paultyng paultyng paultyng approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

Walk hierarchy asynchronously
2 participants
@radeksimko @paultyng