settings: Support relative paths to root modules #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paultyng
approved these changes
Jul 24, 2020
paultyng
approved these changes
Jul 24, 2020
radeksimko
force-pushed
the
f-rm-rel-paths
branch
from
f76695b
to
4c65b4a
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #235
It's worth noting that this does not allow the user to just "force-pair" the root module. Any referenced root module still has to reference the folder being opened in the editor as a module, otherwise it will not be matched.
Force-pairing is something we could consider but that would likely require some UI changes, maybe even an entirely separate config option as we wouldn't be able to pick the right path from a list. Also I would like to first understand the use cases for such feature before implementing it.