Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace most of terraform/exec w/ terraform-exec #271

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Oct 6, 2020

This should address all of these points #268 (comment) and replace as much of the old package as possible.

Closes #266
Closes #268

@radeksimko radeksimko force-pushed the f-terraform-exec branch 5 times, most recently from e43ec08 to 8ec533d Compare October 7, 2020 11:38
@radeksimko radeksimko mentioned this pull request Oct 7, 2020
@radeksimko radeksimko marked this pull request as ready for review October 7, 2020 14:27
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but need to tidy and vendor

Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVM just noticed we stopped vendoring

@radeksimko radeksimko merged commit 7666e9d into master Oct 8, 2020
@radeksimko radeksimko deleted the f-terraform-exec branch October 8, 2020 10:06
@ghost
Copy link

ghost commented Nov 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use terraform-exec
2 participants