Expose terraform.init as command #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-cmd-init
branch
2 times, most recently
from
a1c9569
to
2f1de71
Compare
radeksimko
force-pushed
the
f-cmd-init
branch
from
2f1de71
to
97872ea
Compare
appilon
approved these changes
Dec 2, 2020
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may seem like I bundled two unrelated features into a single PR here (exposing init as command and reporting progress), but I believe that providing some form of feedback when a command is called is essential in this case, since
initcan often take seconds to finish.I also added the progress reporting into the existing
didOpenworkflow is just because "why not". 😄Progress UX
Error UX