Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display provider versions in completion/hover detail #329

Merged
merged 3 commits into from
Dec 4, 2020

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Dec 4, 2020

Closes #303
Depends on hashicorp/terraform-schema#8

This could also enable us to eventually tone down the current "No root module" messaging as this provides more subtle way of informing the user about potential discrepancies.

We could potentially go even further and also display where the schema came from (e.g. preloaded, locally sourced), but what may be far more valuable to know is whether the schema version matches the provider version constraints in the code.


UX

Screenshot 2020-12-04 at 11 37 33

Screenshot 2020-12-04 at 11 37 56

@radeksimko radeksimko marked this pull request as ready for review December 4, 2020 10:49
@radeksimko radeksimko requested a review from a team December 4, 2020 10:50
@radeksimko radeksimko merged commit f1f0a75 into main Dec 4, 2020
@radeksimko radeksimko deleted the f-detail-provider-versions branch December 4, 2020 17:40
@ghost
Copy link

ghost commented Jan 3, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display provider versions in completion/hover detail
2 participants