Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve messaging when TF installation is not found #401

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

radeksimko
Copy link
Member

Closes #398

I did initially consider printing out the $PATH too, but then I realized it may not even fit in a popup such as the one VS Code uses, or that it can't be formatted in any useful way.

@radeksimko radeksimko added the enhancement New feature or request label Feb 8, 2021
@radeksimko radeksimko requested a review from a team February 8, 2021 16:44
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@radeksimko radeksimko merged commit 47ced5a into main Feb 9, 2021
@radeksimko radeksimko deleted the f-enrich-tf-exec-error branch February 9, 2021 09:09
@ghost
Copy link

ghost commented Mar 11, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
2 participants