textDocument/publishDiagnostics: Publish any source-less warnings or errors #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
b-publish-sourceless-diags
branch
from
089145c
to
88116fd
Compare
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would suppress any diagnostics which do not have source context associated with them.
This for example means that if user attempted to run
validateon uninitialized module they wouldn't receive any feedback at all - as if the configuration is valid.This PR makes such diagnostics visible.
LSP technically makes source range mandatory in the protocol - which seems kinda awkward given that they allow diagnostic to be associated with a directory URI.
We can however just pass an "empty"
0,0-0,0range which satisfies the protocol and allows the diagnostic to still be displayed, as demonstrated in VS Code: