Support standalone (not autoloaded) *.tfvars files
#621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-any-tfvars
branch
from
e4e1051
to
13e43e2
Compare
radeksimko
changed the title
*.tfvars files
radeksimko
force-pushed
the
f-any-tfvars
branch
from
13e43e2
to
6b6e5ec
Compare
radeksimko
commented
Aug 18, 2021
| @@ -1 +1,2 @@ | |||
| *.go text eol=lf | |||
| *.tf text eol=lf | |||
There was a problem hiding this comment.
This is to avoid test failures (in CI) on Windows caused by converted line endings in test config files.
radeksimko
force-pushed
the
f-any-tfvars
branch
from
6b6e5ec
to
83b4bfe
Compare
jpogran
approved these changes
Aug 25, 2021
Terraform Editor Experience Public Roadmap
automation
moved this from In Progress
to Done
Aug 25, 2021
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #562
This PR decouples some logic of the overgrown
modulepackage intoastandparser:parseris responsible for parsing*.tfand*.tfvarsfiles - and potentially other future files we will supportastis responsible for representing the files and diagnostics so that they can be filtered accordingly (e.g. we can distinguish between autoloaded and not-autoloaded tfvars files)