Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for JSON variable files #697

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Implement support for JSON variable files #697

merged 2 commits into from
Nov 9, 2021

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Nov 5, 2021

This PR adds support for collecting variables from *.tfvars.json and *.auto.tfvars.json files in addition to *.tfvars.

Closes #519.


UX Impact

Symbols

Users can find variables declared in JSON files when seeking symbols across the workspace.

CleanShot 2021-11-08 at 15 18 29@2x

Problems

Users can find a list of issues for JSON files in the problems tab.

CleanShot 2021-11-09 at 10 38 40@2x

internal/terraform/ast/variables.go Outdated Show resolved Hide resolved
@radeksimko radeksimko added the enhancement New feature or request label Nov 8, 2021
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbanck dbanck merged commit 15bb6e1 into main Nov 9, 2021
Terraform Editor Experience Public Roadmap automation moved this from In Progress to Done Nov 9, 2021
@dbanck dbanck deleted the f-519-json-vars branch November 9, 2021 09:58
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Support JSON variable files (*.tfvars.json)
2 participants