Add version to module calls #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
reviewed
Apr 14, 2022
There was a problem hiding this comment.
The code LGTM, but I think we should create an issue upstream in https://github.com/microsoft/vscode to clarify the behaviour when both link & go-to-definition is associated with the same range.
I can test & re-review once the upstream PRs are merged and this is rebased.
5 tasks
dbanck
force-pushed
the
f-add-version-to-module-calls
branch
from
ec06d5e
to
a69ec20
Compare
2 tasks
4 tasks
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
This PR populates the version field for
ModuleCalland pulls in the latestterraform-schemaandhcl-langchanges.All this enables linking the source attribute for remote modules to the documentation.