Subscribe to updates of module.providers data #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpogran
added a commit
to hashicorp/vscode-terraform
that referenced
this pull request
Apr 29, 2022
This commit automatically refreshes the Terraform Providers View when providers change in open document. This introduces a StaticFeature which registers a handler for the `client.refreshModuleProviders` request which terraform-ls can call to refresh the data shown in the Terraform Providers view. The terraform-ls server was modified to send `client.refreshModuleProviders` requests in hashicorp/terraform-ls#902
jpogran
added a commit
to hashicorp/vscode-terraform
that referenced
this pull request
Apr 29, 2022
This commit automatically refreshes the Terraform Providers View when providers change in open document. This introduces a StaticFeature which registers a handler for the `client.refreshModuleProviders` request which terraform-ls can call to refresh the data shown in the Terraform Providers view. The terraform-ls server was modified to send `client.refreshModuleProviders` requests in hashicorp/terraform-ls#902
jpogran
force-pushed
the
gh-723-module-providers-sub
branch
2 times, most recently
from
67bb8b8
to
e3cc8a8
Compare
Adds support for a client to register a command that will refresh clide side data based on changes the server has detected in the workspace. This specifically adds a new command to refresh the module providers shown client side. The existing Module hook system is used to detect changes in the workspace and notify the client that data has changed.
jpogran
force-pushed
the
gh-723-module-providers-sub
branch
from
e3cc8a8
to
a7bf07e
Compare
jpogran
added a commit
to hashicorp/vscode-terraform
that referenced
this pull request
Apr 29, 2022
This commit automatically refreshes the Terraform Module Calls View when providers change in open document. This introduces a StaticFeature which registers a handler for the `client.refreshModuleCalls` request which terraform-ls can call to refresh the data shown in the Terraform Module Calls view. The terraform-ls server was modified to send `client.refreshModuleCalls` requests in hashicorp/terraform-ls#902
jpogran
force-pushed
the
gh-723-module-providers-sub
branch
from
db03c5b
to
a7bf07e
Compare
radeksimko
approved these changes
May 3, 2022
There was a problem hiding this comment.
LGTM 
I found what I believe is unrelated bug while testing this, filed under #906 - we can take a look in a separate PR later.
jpogran
added a commit
to hashicorp/vscode-terraform
that referenced
this pull request
May 3, 2022
…in open document (#1084) This commit automatically refreshes the Terraform Providers View when providers change in open document. This introduces a StaticFeature which registers a handler for the `client.refreshModuleProviders` request which terraform-ls can call to refresh the data shown in the Terraform Providers view. The terraform-ls server was modified to send `client.refreshModuleProviders` requests in hashicorp/terraform-ls#902
jpogran
added a commit
to hashicorp/vscode-terraform
that referenced
this pull request
May 4, 2022
This commit automatically refreshes the Terraform Module Calls View when providers change in open document. This introduces a StaticFeature which registers a handler for the `client.refreshModuleCalls` request which terraform-ls can call to refresh the data shown in the Terraform Module Calls view. The terraform-ls server was modified to send `client.refreshModuleCalls` requests in hashicorp/terraform-ls#902
jpogran
added a commit
to hashicorp/vscode-terraform
that referenced
this pull request
May 4, 2022
This commit automatically refreshes the Terraform Module Calls View when providers change in open document. This introduces a StaticFeature which registers a handler for the `client.refreshModuleCalls` request which terraform-ls can call to refresh the data shown in the Terraform Module Calls view. The terraform-ls server was modified to send `client.refreshModuleCalls` requests in hashicorp/terraform-ls#902
jpogran
added a commit
to hashicorp/vscode-terraform
that referenced
this pull request
May 9, 2022
This commit automatically refreshes the Terraform Module Calls View when providers change in open document. This introduces a StaticFeature which registers a handler for the `client.refreshModuleCalls` request which terraform-ls can call to refresh the data shown in the Terraform Module Calls view. The terraform-ls server was modified to send `client.refreshModuleCalls` requests in hashicorp/terraform-ls#902
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for a client to register a command that will refresh clide side data based on changes the server has detected in the workspace.
This specifically adds a new command to refresh the module providers shown client side. The existing Module hook system is used to detect changes in the workspace and notify the client that data has changed.