job: Introduce explicit priority for jobs #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-job-priority
branch
from
aee60fe
to
ea86b87
Compare
radeksimko
force-pushed
the
f-job-priority
branch
from
ea86b87
to
29caa85
Compare
dbanck
approved these changes
Jun 30, 2022
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #962
I also found one more bug where we'd schedule new jobs as if they always involve closed directories - meaning that these would only get picked up by the lower-priority scheduler which is more likely to be busy indexing walked directories.
Therefore the fix (last commit) should further improve performance as we now correctly treat any new job for open directory as high priority.
UX Impact
This simulates 10sec delay when obtaining data from the Module Registry.
Before
Screen.Recording.2022-06-28.at.11.09.51.mov
After
Screen.Recording.2022-06-28.at.11.10.34.mov