Default id to "Read-Only" + allow for empty blocks/nested attributes to be documented
#134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still allows arbitrary definition of `id` where a tailor-made `.Description` can be provided: it's just the default that is changing to something more sensible. Also, updated README to guide developers. Co-authored-by: Nicholas Muesch <nicholas.muesch@datadoghq.com> Co-authored-by: Oliver Ford <dev.github@ojford.com>
detro
changed the title
id to "Read-Only" + allow for empty blocks/nested attributes to be documented
1 task
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #46
Closes #99
This PR is a cherry-pick-like one: there are key fixes we want to land in
v0.8.0, and given PRs have been open for a long while, we want to support them without additional burden to the original contributors.Of course, authorship is preserved.
See the linked content for more context about each fix.
Big thank you to: @ovandriyanov, @nmuesch, @OJFord