Skip to content

Commit

Permalink
delete duplicate tests and add name params
Browse files Browse the repository at this point in the history
  • Loading branch information
@austinvalle
austinvalle committed Mar 20, 2024
1 parent c91b157 commit 5c1f575
Showing 1 changed file with 40 additions and 87 deletions.
127 changes: 40 additions & 87 deletions function/definition_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -243,101 +243,52 @@ func TestDefinitionValidateImplementation(t *testing.T) {
definition: function.Definition{
Parameters: []function.Parameter{
function.MapParameter{
Name: "map_with_dynamic",
ElementType: types.DynamicType,
},
},
Return: function.StringReturn{},
},
expected: diag.Diagnostics{
diag.NewErrorDiagnostic(
"Invalid Function Definition",
"When validating the function definition, an implementation issue was found. "+
"This is always an issue with the provider and should be reported to the provider developers.\n\n"+
"Parameter \"param1\" at position 0 contains a collection type with a nested dynamic type.\n\n"+
"Dynamic types inside of collections are not currently supported in terraform-plugin-framework. "+
"If underlying dynamic values are required, replace the \"param1\" parameter definition with DynamicParameter instead.",
),
},
},
"variadic-param-dynamic-in-collection": {
definition: function.Definition{
Parameters: []function.Parameter{
function.StringParameter{},
function.StringParameter{},
},
VariadicParameter: function.SetParameter{
ElementType: types.DynamicType,
},
Return: function.StringReturn{},
},
expected: diag.Diagnostics{
diag.NewErrorDiagnostic(
"Invalid Function Definition",
"When validating the function definition, an implementation issue was found. "+
"This is always an issue with the provider and should be reported to the provider developers.\n\n"+
"Variadic parameter \"varparam\" contains a collection type with a nested dynamic type.\n\n"+
"Dynamic types inside of collections are not currently supported in terraform-plugin-framework. "+
"If underlying dynamic values are required, replace the variadic parameter definition with DynamicParameter instead.",
),
},
},
"return-dynamic-in-collection": {
definition: function.Definition{
Return: function.ListReturn{
ElementType: types.DynamicType,
},
},
expected: diag.Diagnostics{
diag.NewErrorDiagnostic(
"Invalid Function Definition",
"When validating the function definition, an implementation issue was found. "+
"This is always an issue with the provider and should be reported to the provider developers.\n\n"+
"Return contains a collection type with a nested dynamic type.\n\n"+
"Dynamic types inside of collections are not currently supported in terraform-plugin-framework. "+
"If underlying dynamic values are required, replace the return definition with DynamicReturn instead.",
),
},
},
"param-dynamic-in-collection": {
definition: function.Definition{
Parameters: []function.Parameter{
function.MapParameter{
ElementType: types.DynamicType,
},
expected: function.DefinitionValidateResponse{
Diagnostics: diag.Diagnostics{
diag.NewErrorDiagnostic(
"Invalid Function Definition",
"When validating the function definition, an implementation issue was found. "+
"This is always an issue with the provider and should be reported to the provider developers.\n\n"+
"Parameter \"map_with_dynamic\" at position 0 contains a collection type with a nested dynamic type.\n\n"+
"Dynamic types inside of collections are not currently supported in terraform-plugin-framework. "+
"If underlying dynamic values are required, replace the \"map_with_dynamic\" parameter definition with DynamicParameter instead.",
),
},
Return: function.StringReturn{},
},
expected: diag.Diagnostics{
diag.NewErrorDiagnostic(
"Invalid Function Definition",
"When validating the function definition, an implementation issue was found. "+
"This is always an issue with the provider and should be reported to the provider developers.\n\n"+
"Parameter \"param1\" at position 0 contains a collection type with a nested dynamic type.\n\n"+
"Dynamic types inside of collections are not currently supported in terraform-plugin-framework. "+
"If underlying dynamic values are required, replace the \"param1\" parameter definition with DynamicParameter instead.",
),
},
},
"variadic-param-dynamic-in-collection": {
definition: function.Definition{
Parameters: []function.Parameter{
function.StringParameter{},
function.StringParameter{},
function.StringParameter{
Name: "string_param1",
},
function.StringParameter{
Name: "string_param2",
},
},
VariadicParameter: function.SetParameter{
Name: "set_with_dynamic",
ElementType: types.DynamicType,
},
Return: function.StringReturn{},
},
expected: diag.Diagnostics{
diag.NewErrorDiagnostic(
"Invalid Function Definition",
"When validating the function definition, an implementation issue was found. "+
"This is always an issue with the provider and should be reported to the provider developers.\n\n"+
"Variadic parameter \"varparam\" contains a collection type with a nested dynamic type.\n\n"+
"Dynamic types inside of collections are not currently supported in terraform-plugin-framework. "+
"If underlying dynamic values are required, replace the variadic parameter definition with DynamicParameter instead.",
),
expected: function.DefinitionValidateResponse{
Diagnostics: diag.Diagnostics{
diag.NewErrorDiagnostic(
"Invalid Function Definition",
"When validating the function definition, an implementation issue was found. "+
"This is always an issue with the provider and should be reported to the provider developers.\n\n"+
"Variadic parameter \"set_with_dynamic\" contains a collection type with a nested dynamic type.\n\n"+
"Dynamic types inside of collections are not currently supported in terraform-plugin-framework. "+
"If underlying dynamic values are required, replace the variadic parameter definition with DynamicParameter instead.",
),
},
},
},
"return-dynamic-in-collection": {
Expand All @@ -346,15 +297,17 @@ func TestDefinitionValidateImplementation(t *testing.T) {
ElementType: types.DynamicType,
},
},
expected: diag.Diagnostics{
diag.NewErrorDiagnostic(
"Invalid Function Definition",
"When validating the function definition, an implementation issue was found. "+
"This is always an issue with the provider and should be reported to the provider developers.\n\n"+
"Return contains a collection type with a nested dynamic type.\n\n"+
"Dynamic types inside of collections are not currently supported in terraform-plugin-framework. "+
"If underlying dynamic values are required, replace the return definition with DynamicReturn instead.",
),
expected: function.DefinitionValidateResponse{
Diagnostics: diag.Diagnostics{
diag.NewErrorDiagnostic(
"Invalid Function Definition",
"When validating the function definition, an implementation issue was found. "+
"This is always an issue with the provider and should be reported to the provider developers.\n\n"+
"Return contains a collection type with a nested dynamic type.\n\n"+
"Dynamic types inside of collections are not currently supported in terraform-plugin-framework. "+
"If underlying dynamic values are required, replace the return definition with DynamicReturn instead.",
),
},
},
},
"conflicting-param-names": {
Expand Down

0 comments on commit 5c1f575

Please sign in to comment.