Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema: Fix nesting mode for data source, resource and provider map, set and single nested attribute #560

Closed
bendbennett opened this issue Nov 29, 2022 · 1 comment · Fixed by #561
Closed

schema: Fix nesting mode for data source, resource and provider map, set and single nested attribute #560

bendbennett opened this issue Nov 29, 2022 · 1 comment · Fixed by #561
Labels
bug Something isn't working

Comments

@bendbennett
Copy link
Contributor

Module version

main @55244fe874b7c426a0ae430e3a6c67d768a40120

Relevant source code

The nesting mode returned is incorrect for the type (i.e., NestingModeList is returned for SetNestedAttribute).

// GetNestingMode always returns NestingModeList.
func (a SetNestedAttribute) GetNestingMode() fwschema.NestingMode {
	return fwschema.NestingModeList
}
@bendbennett bendbennett added the bug Something isn't working label Nov 29, 2022
bendbennett added a commit that referenced this issue Nov 29, 2022
@bendbennett
Fix nesting mode for map, set and single nested attribute within data…
c71c956 
…source, provider and resource schema (#560)
@bendbennett bendbennett mentioned this issue Nov 29, 2022
Merged
bendbennett added a commit that referenced this issue Nov 29, 2022
@bendbennett
Adding changelog entry (#560)
66b4c7c
bendbennett added a commit that referenced this issue Nov 29, 2022
@bendbennett
Removing unneeded changelog entry (#560)
35f9342
bendbennett added a commit that referenced this issue Nov 29, 2022
@bendbennett
Fix nesting mode for map, set and single nested attribute within data…
abe43b2 
… source, provider and resource schema (#561)

* Fix nesting mode for map, set and single nested attribute within datasource, provider and resource schema (#560)

* Adding changelog entry (#560)

* Removing unneeded changelog entry (#560)
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@bendbennett