Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: Go pointer value constructors and getters for Bool, Float64, Int64, and String #689

Merged
merged 4 commits into from
Mar 15, 2023
Merged

types: Go pointer value constructors and getters for Bool, Float64, Int64, and String #689

merged 4 commits into from
Mar 15, 2023

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 14, 2023

Closes #649

@bflad bflad added enhancement New feature or request types Issues and pull requests about our types abstraction and implementations. labels Mar 14, 2023
@bflad bflad added this to the v1.2.0 milestone Mar 14, 2023
@bflad bflad requested a review from a team as a code owner March 14, 2023 18:59
austinvalle
austinvalle approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note, otherwise LGTM 🚀

types/basetypes/int64.go Outdated Show resolved Hide resolved
bflad and others added 2 commits March 14, 2023 16:14
bendbennett
bendbennett approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎸

@bflad bflad merged commit 3635f4f into main Mar 15, 2023
@bflad bflad deleted the bflad/types-pointer-handlers branch March 15, 2023 12:49
@ewbankkit ewbankkit mentioned this pull request Mar 24, 2023
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bendbennett bendbennett bendbennett approved these changes

@austinvalle austinvalle austinvalle approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request types Issues and pull requests about our types abstraction and implementations.
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Consider Go Pointer Value Constructors and Getters for Primitive Types
3 participants
@bflad @bendbennett @austinvalle