types/basetypes: Fix Float64Attribute precision comparisons #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvalle
commented
Aug 3, 2023
austinvalle
commented
Aug 3, 2023
bflad
reviewed
Aug 3, 2023
Co-authored-by: Brian Flad <bflad417@gmail.com>
Co-authored-by: Brian Flad <bflad417@gmail.com>
bflad
added
bug
|
Oh wow, surprised that |
bflad
approved these changes
Aug 3, 2023
jharley
added a commit
to honeycombio/terraform-provider-honeycombio
that referenced
this pull request
Aug 3, 2023
Fix included in terraform-plugin-framework v1.3.4 (via hashicorp/terraform-plugin-framework#817) - Closes #335
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #815
Related corner tests: hashicorp/terraform-provider-corner#170
Context
Terraform core's
numbertype can store up to 512 bits of precision for floating numbers. This level of precision is typically only encountered when performing an arithmetic operation like below:$ terraform console > 1 - 0.99 0.010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000003The
Float64Attributeunderlying value of Go's built-infloat64type was losing this precision and responding with invalid plan value errors seen in #815 .Solution
This PR replaces the underlying value of
Float64Attributewith a*big.Floattype, which is already supported interraform-plugin-go. Semantic equality logic has also been implemented to ensure thatComputedvalues do not replace more precise prior values.