tfprotov5+tfprotov6: Replace usage of diagnostics in CallFunction RPC with function error #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with function error Reference: hashicorp/terraform#34603 The next version of the plugin protocol (5.5/6.5) includes support for provider defined functions. This change modifies the response returned from the CallFunction RPC, replacing diagnostics with function error.
bendbennett
added
the
breaking-change
bendbennett
force-pushed
the
pdf-err-handling
branch
from
1819845
to
ce15b8a
Compare
bflad
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Looks good to me 🚀 Since we know we are breaking the downstream SDKs, I wonder if our changelog here should also call out that this terraform-plugin-go release should only be updated with the upcoming minor versions of those SDKs:
- terraform-plugin-framework@v1.6.0
- terraform-plugin-mux@v0.15.0
- terraform-plugin-sdk/v2@v2.33.0
bendbennett
added a commit
to hashicorp/terraform-plugin-mux
that referenced
this pull request
Feb 23, 2024
Reference: hashicorp/terraform-plugin-go#380 The next versions of the plugin protocol (5.5/6.5) include support for the CallFunction RPC and server capability. This change includes a modified implementation of the new RPC in all server implementations which accounts for returning a FunctionError rather than Diagnostics.
bendbennett
added a commit
to hashicorp/terraform-plugin-mux
that referenced
this pull request
Feb 23, 2024
Reference: hashicorp/terraform-plugin-go#380 The next versions of the plugin protocol (5.5/6.5) include support for the CallFunction RPC and server capability. This change includes a modified implementation of the new RPC in all server implementations which accounts for returning a FunctionError rather than Diagnostics.
bendbennett
added a commit
to hashicorp/terraform-plugin-sdk
that referenced
this pull request
Feb 23, 2024
Reference: hashicorp/terraform-plugin-go#380 Reference: https://developer.hashicorp.com/terraform/plugin/framework/migrating The next versions of the plugin protocol (5.5/6.5) include support for provider defined functions. The terraform-plugin-sdk Go module will not be receiving this feature, however this Go module must be updated to handle the new RPC with errors. Provider developers can implement provider defined functions by introducing terraform-plugin-mux and using their terraform-plugin-sdk based providers in combination with a terraform-plugin-framework provider that contains the provider defined functions.
bendbennett
added a commit
to hashicorp/terraform-plugin-sdk
that referenced
this pull request
Feb 23, 2024
Reference: hashicorp/terraform-plugin-go#380 Reference: https://developer.hashicorp.com/terraform/plugin/framework/migrating The next versions of the plugin protocol (5.5/6.5) include support for provider defined functions. The terraform-plugin-sdk Go module will not be receiving this feature, however this Go module must be updated to handle the new RPC with errors. Provider developers can implement provider defined functions by introducing terraform-plugin-mux and using their terraform-plugin-sdk based providers in combination with a terraform-plugin-framework provider that contains the provider defined functions.
bendbennett
added a commit
to hashicorp/terraform-plugin-mux
that referenced
this pull request
Feb 23, 2024
Reference: hashicorp/terraform-plugin-go#380 The next versions of the plugin protocol (5.5/6.5) include support for the CallFunction RPC and server capability. This change includes a modified implementation of the new RPC in all server implementations which accounts for returning a FunctionError rather than Diagnostics.
|
@bflad @bendbennett routine update from dependabot ("Bump github.com/hashicorp/terraform-plugin-go from 0.21.0 to 0.22.0") now breaks the build |
jacobbednarz
added a commit
to cloudflare/terraform-provider-cloudflare
that referenced
this pull request
Feb 27, 2024
Pending release of terraform-plugin-framework@v1.6.0 Ref: hashicorp/terraform-plugin-go#380
jacobbednarz
added a commit
to cloudflare/terraform-provider-cloudflare
that referenced
this pull request
Feb 27, 2024
Pending release of terraform-plugin-framework@v1.6.0 Ref: hashicorp/terraform-plugin-go#380
matt-FFFFFF
added a commit
to Azure/terraform-provider-alz
that referenced
this pull request
Feb 27, 2024
jacobbednarz
added a commit
to cloudflare/terraform-provider-cloudflare
that referenced
this pull request
Feb 28, 2024
Pending release of terraform-plugin-framework@v1.6.0 Ref: hashicorp/terraform-plugin-go#380
|
The following releases are all now available: If you are upgrading to terraform-plugin-go@v0.22.0 and you are using terraform-plugin-framework, terraform-plugin-mux and/or terraform-plugin-sdk/v2, you will also need to upgrade those Go modules. |
rishabh-bector
pushed a commit
to rishabh-bector/terraform-provider-cloudflare
that referenced
this pull request
Mar 1, 2024
Pending release of terraform-plugin-framework@v1.6.0 Ref: hashicorp/terraform-plugin-go#380
rishabh-bector
pushed a commit
to rishabh-bector/terraform-provider-cloudflare
that referenced
this pull request
Mar 1, 2024
Pending release of terraform-plugin-framework@v1.6.0 Ref: hashicorp/terraform-plugin-go#380
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: hashicorp/terraform#34603
The next version of the plugin protocol (5.5/6.5) includes support for provider defined functions. This change modifies the response returned from the CallFunction RPC, replacing diagnostics with function error.