Fix NewValue checks to be properly recursive #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the checks that NewValue runs to ensure that a value can be used with a Type to properly handle DynamicPseudoTypes nested in complex types. Builds on and supersedes #76. Should we make this part of the behavior for `.Is`? My gut says "no", because `Is` is supposed to be about checking whether a type is semantically similar, not that it can be used as another type. Maybe we want a `Fulfills` method, similar to Is, that does this? I don't know that this behavior needs to be exported, though... Fixes a bug in #74 that would panic for complex types containing DynamicPseudoTypes.
Add a test to exercise the object-with-a-dynamic-attribute logic we fixed.
Add tests for all the complex types, and make sure types that require elements be the same type get only elements of the same exact type.
paddycarver
force-pushed
the
paddy_fix_newvalue
branch
from
6c7260b
to
aa0b18a
Compare
kmoe
approved these changes
Apr 21, 2021
|
I would like to, in 0.4.0, do some work on Is to make this cleaner and have less magic behavior:
I just don't want to hold up 0.3.0 for that work, it's a big enough release already. I'll write up an issue for it. |
This was referenced Apr 21, 2021
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the checks that NewValue runs to ensure that a value can be used
with a Type to properly handle DynamicPseudoTypes nested in complex
types. Builds on and supersedes #76.
Should we make this part of the behavior for
.Is? My gut says "no",because
Isis supposed to be about checking whether a type issemantically similar, not that it can be used as another type. Maybe we
want a
Fulfillsmethod, similar to Is, that does this? I don't knowthat this behavior needs to be exported, though...
Fixes a bug in #74 that would panic for complex types containing
DynamicPseudoTypes.