all: Modify CallFunction implementations #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: hashicorp/terraform-plugin-go#380 The next versions of the plugin protocol (5.5/6.5) include support for the CallFunction RPC and server capability. This change includes a modified implementation of the new RPC in all server implementations which accounts for returning a FunctionError rather than Diagnostics.
bendbennett
force-pushed
the
bendbennett/pdf-error-handling
branch
from
0c075b1
to
57ce86f
Compare
bendbennett
commented
Feb 23, 2024
|
|
||
| require ( | ||
| github.com/google/go-cmp v0.6.0 | ||
| github.com/hashicorp/terraform-plugin-go v0.21.0 | ||
| github.com/hashicorp/terraform-plugin-go v0.22.0 |
There was a problem hiding this comment.
Running go get github.com/hashicorp/terraform-plugin-go results in the addition of the following entry to go.mod:
toolchain go1.21.6
Resulting in a CI failure:
go: errors parsing go.mod:
/home/runner/work/terraform-plugin-mux/terraform-plugin-mux/go.mod:[5](https://github.com/hashicorp/terraform-plugin-mux/actions/runs/8017456549/job/21901361119#step:4:6): unknown directive: toolchain
Given that our CI runs both Go 1.20 and 1.21, I removed this directive, but perhaps this should be handled differently?
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: hashicorp/terraform-plugin-go#380
Reference: https://github.com/hashicorp/terraform-providers-devex-internal/issues/175
The next versions of the plugin protocol (5.5/6.5) include support for the CallFunction RPC and server capability. This change includes a modified implementation of the new RPC in all server implementations which accounts for returning a FunctionError rather than Diagnostics.