helper/schema: Compile valid field name regex once (#1062)

hashicorp · Oct 10, 2022 · 3495894 · 3495894
1 parent 6c09938
commit 3495894
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/helper/schema/schema.go b/helper/schema/schema.go
@@ -1093,9 +1093,10 @@ func checkKeysAgainstSchemaFlags(k string, keys []string, topSchemaMap schemaMap
 	return nil
 }
 
+var validFieldNameRe = regexp.MustCompile("^[a-z0-9_]+$")
+
 func isValidFieldName(name string) bool {
-	re := regexp.MustCompile("^[a-z0-9_]+$")
-	return re.MatchString(name)
+	return validFieldNameRe.MatchString(name)
 }
 
 // resourceDiffer is an interface that is used by the private diff functions.