-
Notifications
You must be signed in to change notification settings - Fork 230
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Stop overriding log output in plugin.Serve in tests.
When testing, we don't want to override where log output gets sent--the test framework takes care of that itself. go-plugin has disabled its use of log.SetOutput for us, but #639 introduced a log.SetOutput in plugin.Serve. This adds a plugin.ServeOpt property to disable that log.SetOutput call so we can finally have tests where log lines don't randomly show up in test output.
- Loading branch information
1 parent
6f728bc
commit def5710
Showing
2 changed files
with
21 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters