Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Expected Minimum Go Version to 1.19 #1162

Closed
bendbennett opened this issue Mar 3, 2023 · 1 comment · Fixed by #1163
Closed

Bump Expected Minimum Go Version to 1.19 #1162

bendbennett opened this issue Mar 3, 2023 · 1 comment · Fixed by #1163
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Milestone

Comments

@bendbennett
Copy link
Contributor

SDK version

v2.25.0

Use cases

Following the Go support policy and given the ecosystem availability of the latest Go minor version, it's time to upgrade. This will ensure that this project can use recent improvements to the Go runtime, standard library functionality, and continue to receive security updates

Proposal

  • Run the following commands to upgrade the Go module files and automatically fix outdated Go code:
go mod edit -go=1.19
go mod tidy
go fix ./...
  • Ensure any GitHub Actions workflows (.github/workflows/*.yml) use 1.20 in place of any 1.19 and 1.19 in place of any 1.18 or earlier
  • Ensure the README or any Contributing documentation notes the Go 1.19 expected minimum
  • (Not applicable to all projects) Ensure the .go-version is at least 1.19 or later

References

@bendbennett bendbennett added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Mar 3, 2023
@bendbennett bendbennett added this to the v2.26.0 milestone Mar 3, 2023
bendbennett added a commit that referenced this issue Mar 3, 2023
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant