validation: add StringIsEmpty, StringIsWhitespace, StringIsNotEmpty, StringIsNotWhitespace, StringIsBase64, UUID, UUIDOrEmpty #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katbyte
force-pushed
the
kt/add-azurerm-validators-1
branch
from
cbd4193
to
cb19d7a
Compare
katbyte
changed the title
appilon
suggested changes
Jan 14, 2020
| ) | ||
|
|
||
| // UUIDRegExp is a Regular Expression that can be used to validate UUIDs | ||
| var UUIDRegExp = regexp.MustCompile("^[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-4[a-fA-F0-9]{3}-[8|9|aA|bB][a-fA-F0-9]{3}-[a-fA-F0-9]{12}$") |
helper/validation/uuid.go
Outdated
| } | ||
|
|
||
| // UUID is a ValidateFunc that ensures a string is empty or can be parsed as UUID | ||
| func UUIDOrEmpty(i interface{}, k string) (warnings []string, errors []error) { |
There was a problem hiding this comment.
I would prefer encourage composition with validation.Any.
validation.Any(validation.UUID, validation.StringIsEmpty)
I mentioned earlier it might be nice to add StringIsEmpty as well
katbyte
changed the title
appilon
suggested changes
Jan 14, 2020
Co-Authored-By: appilon <apilon@hashicorp.com>
appilon
approved these changes
Jan 14, 2020
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.