TypeSet Check Heuristic #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
style set indexes into a TypeSet when using the binary driver. Currently the check is skipped, but it could be changed to error should that be a better behavior
|
This is a great UX improvement and fills the gap between binary testing in v1 and the fix for #196 (which I still hope I can land on v1 as well as v2). If we're concerned about false positives, could we instead run the heuristic and log the warning only if the attribute check fails? |
bflad
reviewed
Apr 29, 2020
change from warn/skip to error
paultyng
approved these changes
Apr 29, 2020
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change can assist users when enabling the binary driver. Previously any checks that addressed through TypeSet hashes would error confusingly (just claim the resource does not exist) as the binary driver's shimmed state did not represent TypeSet addresses.
A small hack/flag needed to be added onto
terraform.State, but the docs clearly state it's not for external use.