-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Sidebar to Match Design Spec #1048
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ This looks great to me! 👍 Mostly looking at JSON formatting, since I don't have any strong opinions on the content & design side
* Docs Changes for DevDot Migration (#1036) * Remove mentions of HashiCorp Learn * Remaining updates - terraform.io, mentions of docs nav * Update website/docs/plugin/sdkv2/resources/import.mdx Co-authored-by: Matthew Garrell <69917312+mgarrell777@users.noreply.github.com> * Update website/docs/plugin/sdkv2/testing/index.mdx Co-authored-by: Matthew Garrell <69917312+mgarrell777@users.noreply.github.com> * Update website/docs/plugin/sdkv2/testing/acceptance-tests/index.mdx Co-authored-by: Matthew Garrell <69917312+mgarrell777@users.noreply.github.com> * Update website/docs/plugin/sdkv2/best-practices/index.mdx Co-authored-by: Matthew Garrell <69917312+mgarrell777@users.noreply.github.com> * Update website/docs/plugin/sdkv2/guides/v2-upgrade-guide.mdx Co-authored-by: Matthew Garrell <69917312+mgarrell777@users.noreply.github.com> * Update website/docs/plugin/sdkv2/resources/index.mdx Co-authored-by: Matthew Garrell <69917312+mgarrell777@users.noreply.github.com> * Update website/docs/plugin/sdkv2/testing/index.mdx Co-authored-by: Matthew Garrell <69917312+mgarrell777@users.noreply.github.com> Co-authored-by: Matthew Garrell <69917312+mgarrell777@users.noreply.github.com> * Updating Sidebar to Match Design Spec (#1048) * Updating Sidebar to Match Design Spec * Update website/data/plugin-sdk-nav-data.json * Update website/data/plugin-sdk-nav-data.json * Update index.mdx (#1053) * Update index.mdx * Update website/docs/plugin/sdkv2/index.mdx Co-authored-by: Matthew Garrell <69917312+mgarrell777@users.noreply.github.com>
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
The DevDot process flagged two issues with the sidebar:
This PR removes the learn link and limits the logging section to one pointer page and the page about HTTP transport. These pages DO exist in this documentation set but then points users to the external logging documentation set. I think this is a happy medium that will get users where they need to go, let them know logging stuff exists, but not provide unexpected links to another doc set.
New Sidebar