Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helper/resource: Add missing equals for type aliases #1177

Merged
merged 2 commits into from
Mar 21, 2023
Merged

helper/resource: Add missing equals for type aliases #1177

merged 2 commits into from
Mar 21, 2023

Conversation

bflad
Copy link
Member

@bflad bflad commented Mar 21, 2023

Closes #1176

@bflad bflad added the bug Something isn't working label Mar 21, 2023
@bflad bflad added this to the v2.26.1 milestone Mar 21, 2023
@bflad bflad requested a review from a team as a code owner March 21, 2023 12:57
@bflad bflad mentioned this pull request Mar 21, 2023
Closed
austinvalle
austinvalle approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, adding the type alias revealed two lints, but other than those 🚀

@bflad
helper/resource: Fix unconvert reports
d4c5b5e 
```
helper/resource/aliases.go:95:57: unnecessary conversion (unconvert)
        return retry.RetryContext(ctx, timeout, retry.RetryFunc(f))
                                                               ^
helper/resource/aliases.go:104:45: unnecessary conversion (unconvert)
        return retry.Retry(timeout, retry.RetryFunc(f))
                                                   ^
```
@bflad
Copy link
Member Author

bflad commented Mar 21, 2023

I was able to go mod edit -replace with terraform-provider-aws and the linters are now happy, merging!

@bflad bflad merged commit 3232543 into main Mar 21, 2023
@bflad bflad deleted the bflad/resource-type-aliasing branch March 21, 2023 13:14
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@austinvalle austinvalle austinvalle approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v2.26.1
Development

Successfully merging this pull request may close these issues.

v2.26.0 changes cause build failures in some downstream providers
2 participants
@bflad @austinvalle