Deprecate GetOkExists #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paultyng
approved these changes
Mar 11, 2020
appilon
force-pushed
the
fix-getokexists-docs
branch
from
f41279a
to
790fe5b
Compare
paultyng
approved these changes
Mar 11, 2020
appilon
force-pushed
the
fix-getokexists-docs
branch
from
790fe5b
to
6f85388
Compare
|
I need GetOkExists. What is the replacement once you remove it? |
|
@mingfang We won't remove this without a suitable replacement. It's deprecated to turn people away from it as much as possible. If version 2 of the SDK were released today this method would still exist since we have not come up with a replacement. I will update the CHANGELOG stating this |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking a harder stance and really discouraging the use of this method. It will be deprecated but I would not remove it in V2.
closes #283