Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to tfplugin 5.2, map new protocol fields (v1) #353

Merged
merged 6 commits into from
Mar 19, 2020
Merged

Conversation

paultyng
Copy link
Contributor

This is the v1 backport of #349

@paultyng paultyng force-pushed the tfplugin5.2-v1 branch 2 times, most recently from 9892950 to 8b19875 Compare March 18, 2020 14:44
@paultyng paultyng requested a review from a team March 18, 2020 14:44
Borrows some core code from 23acb02cb846fd002e7a0b52904ee88019b33211
@paultyng
Copy link
Contributor Author

cc @appilon @paddycarver , the v1 version of that other PR, not a high priority to get it in to v1, but would be useful for docs/lang server potentially.

Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since its the same as in V2. Please make a changelog entry on master when merged

@paultyng paultyng merged commit 7963e72 into master Mar 19, 2020
@paultyng paultyng deleted the tfplugin5.2-v1 branch March 19, 2020 00:13
@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants