Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract error messages from CLIXML serialised output #74

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Extract error messages from CLIXML serialised output #74

merged 2 commits into from
Jan 19, 2021

Conversation

koikonom
Copy link
Contributor

Powershell will serialise the stderr of a command using CLIXML when the command does not run in a terminal.
This change detects when this is the case and extracts an error message from it, instead of users having to
visually "parse" XML in order to understand when something went wrong

@ghost ghost added size/XXL labels Jan 19, 2021
@koikonom koikonom closed this Jan 19, 2021
@koikonom koikonom deleted the xml branch January 19, 2021 12:30
@koikonom koikonom restored the xml branch January 19, 2021 12:31
@koikonom koikonom reopened this Jan 19, 2021
Copy link
Member

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@koikonom koikonom merged commit deb911d into main Jan 19, 2021
@koikonom koikonom deleted the xml branch January 19, 2021 15:16
@ghost
Copy link

ghost commented Feb 19, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants