Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
r/aws_route53_zone: prevent re-creation with uppercase name
This change handles normalizing the `name` argument such that the value returned from the Route53 API matches what is stored in state. Previously, if the `name` argument included an uppercase letter a persistent difference would be present, causing the resource to be re-created. ```console % make testacc PKG=route53 TESTS=TestAccRoute53Zone_ ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.21.8 test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53Zone_' -timeout 360m --- PASS: TestAccRoute53Zone_disappears (57.95s) --- PASS: TestAccRoute53Zone_delegationSetID (65.40s) --- PASS: TestAccRoute53Zone_basic (66.34s) --- PASS: TestAccRoute53Zone_VPC_single (70.98s) --- PASS: TestAccRoute53Zone_comment (71.97s) --- PASS: TestAccRoute53Zone_multiple (74.73s) --- PASS: TestAccRoute53Zone_tags (76.63s) --- PASS: TestAccRoute53Zone_VPC_multiple (143.04s) --- PASS: TestAccRoute53Zone_VPC_single_forceDestroy (190.01s) --- PASS: TestAccRoute53Zone_VPC_updates (212.37s) --- PASS: TestAccRoute53Zone_forceDestroy (258.91s) --- PASS: TestAccRoute53Zone_ForceDestroy_trailingPeriod (274.02s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/route53 279.439 ``` ```console % make testacc PKG=route53 TESTS=TestAccRoute53ZoneDataSource_ ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.21.8 test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53ZoneDataSource_' -timeout 360m --- PASS: TestAccRoute53ZoneDataSource_id (45.26s) --- PASS: TestAccRoute53ZoneDataSource_name (48.35s) --- PASS: TestAccRoute53ZoneDataSource_tags (65.21s) --- PASS: TestAccRoute53ZoneDataSource_vpc (83.68s) --- PASS: TestAccRoute53ZoneDataSource_serviceDiscovery (102.34s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/route53 107.890s ```
- Loading branch information