Merge branch 'main' into f/migrate-ec2-sdkv2

.changelog/37019.txt

@@ -0,0 +1,7 @@
+```release-note:enhancement
+resource/aws_ecs_service: Add `volume_configuration` argument
+```
+
+```release-note:enhancement
+resource/aws_ecs_task_definition: Add `configure_at_launch` parameter in `volume` argument
+```

.changelog/37218.txt

@@ -0,0 +1,3 @@
+```release-note:new-data-source
+aws_chatbot_slack_workspace
+```

.changelog/37587.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_lightsail_instance: Fix crash when reading a resource that has a key-only tag
+```

.changelog/37611.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_storagegateway_smb_file_share: Fix crash when `cache_attributes` is removed on update
+```

.changelog/37624.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_lambda_function: Remove `replace_security_group_on_destroy` and `replacement_security_group_ids` deprecations, re-implement with alternate workflow
+```

.changelog/37628.txt

@@ -0,0 +1,3 @@
+```release-note:new-resource
+aws_vpc_endpoint_private_dns
+```

.changelog/37643.txt

@@ -0,0 +1,3 @@
+```release-note:new-resource
+aws_lambda_runtime_management_config
+```

.changelog/37646.txt

@@ -0,0 +1,15 @@
+```release-note:bug
+resource/aws_lambda_layer_version: Fix issue when `source_code_hash` forces a replacement even if source code has not changed
+```
+
+```release-note:enhancement
+resource/aws_lambda_layer_version: Add `code_sha256` attribute
+```
+
+```release-note:enhancement
+data-source/aws_lambda_layer_version: Add `code_sha256` attribute
+```
+
+```release-note:note
+data-source/aws_lambda_layer_version: `source_code_hash` attribute has been deprecated in favor of `code_sha256`. Will be removed in a future major version
+```

.changelog/37669.txt

@@ -0,0 +1,15 @@
+```release-note:bug
+resource/aws_lambda_function: Fix issue when `source_code_hash` causes drift even if source code has not changed
+```
+
+```release-note:enhancement
+resource/aws_lambda_function: Add `code_sha256` attribute
+```
+
+```release-note:enhancement
+data-source/aws_lambda_function: Add `code_sha256` attribute
+```
+
+```release-note:note
+data-source/aws_lambda_function: `source_code_hash` attribute has been deprecated in favor of `code_sha256`. Will be removed in a future major version
+```

.changelog/37685.txt

@@ -0,0 +1,6 @@
+```release-note:bug
+resource/aws_route53_zone: Fix incorrect `name_servers` values
+```
+```release-note:bug
+data-source/aws_route53_zone: Fix incorrect `name_servers` values
+```

.changelog/37686.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+data-source/aws_route53_zone: Permit both `name` and `zone_id` arguments when one is an empty string
+```

.ci/.semgrep-test-constants.yml

@@ -75,6 +75,33 @@ rules:
     pattern: '"basic"'
     severity: ERROR
     fix: "acctest.CtBasic"
+  - id: literal-CertificatePEM-string-test-constant
+    languages: [go]
+    message: Use the constant `acctest.CtCertificatePEM` for the string literal "certificate_pem" in test files
+    paths:
+      include:
+        - "internal/service/**/*_test.go"
+    pattern: '"certificate_pem"'
+    severity: ERROR
+    fix: "acctest.CtCertificatePEM"
+  - id: literal-Disappears-string-test-constant
+    languages: [go]
+    message: Use the constant `acctest.CtDisappears` for the string literal "disappears" in test files
+    paths:
+      include:
+        - "internal/service/**/*_test.go"
+    pattern: '"disappears"'
+    severity: ERROR
+    fix: "acctest.CtDisappears"
+  - id: literal-False-string-test-constant
+    languages: [go]
+    message: Use the constant `acctest.CtFalse` for the string literal "false" in test files
+    paths:
+      include:
+        - "internal/service/**/*_test.go"
+    pattern: '"false"'
+    severity: ERROR
+    fix: "acctest.CtFalse"
   - id: literal-FalseCaps-string-test-constant
     languages: [go]
     message: Use the constant `acctest.CtFalseCaps` for the string literal "FALSE" in test files
@@ -102,6 +129,51 @@ rules:
     pattern: '"key2"'
     severity: ERROR
     fix: "acctest.CtKey2"
+  - id: literal-Name-string-test-constant
+    languages: [go]
+    message: Use the constant `acctest.CtName` for the string literal "name" in test files
+    paths:
+      include:
+        - "internal/service/**/*_test.go"
+    pattern: '"name"'
+    severity: ERROR
+    fix: "acctest.CtName"
+  - id: literal-OverlapKey1-string-test-constant
+    languages: [go]
+    message: Use the constant `acctest.CtOverlapKey1` for the string literal "overlapkey1" in test files
+    paths:
+      include:
+        - "internal/service/**/*_test.go"
+    pattern: '"overlapkey1"'
+    severity: ERROR
+    fix: "acctest.CtOverlapKey1"
+  - id: literal-OverlapKey2-string-test-constant
+    languages: [go]
+    message: Use the constant `acctest.CtOverlapKey2` for the string literal "overlapkey2" in test files
+    paths:
+      include:
+        - "internal/service/**/*_test.go"
+    pattern: '"overlapkey2"'
+    severity: ERROR
+    fix: "acctest.CtOverlapKey2"
+  - id: literal-PrivateKeyPEM-string-test-constant
+    languages: [go]
+    message: Use the constant `acctest.CtPrivateKeyPEM` for the string literal "private_key_pem" in test files
+    paths:
+      include:
+        - "internal/service/**/*_test.go"
+    pattern: '"private_key_pem"'
+    severity: ERROR
+    fix: "acctest.CtPrivateKeyPEM"
+  - id: literal-ProviderKey1-string-test-constant
+    languages: [go]
+    message: Use the constant `acctest.CtProviderKey1` for the string literal "providerkey1" in test files
+    paths:
+      include:
+        - "internal/service/**/*_test.go"
+    pattern: '"providerkey1"'
+    severity: ERROR
+    fix: "acctest.CtProviderKey1"
   - id: literal-ProviderTags-string-test-constant
     languages: [go]
     message: Use the constant `acctest.CtProviderTags` for the string literal "provider_tags" in test files
@@ -129,6 +201,42 @@ rules:
     pattern: '"rName"'
     severity: ERROR
     fix: "acctest.CtRName"
+  - id: literal-ResourceKey1-string-test-constant
+    languages: [go]
+    message: Use the constant `acctest.CtResourceKey1` for the string literal "resourcekey1" in test files
+    paths:
+      include:
+        - "internal/service/**/*_test.go"
+    pattern: '"resourcekey1"'
+    severity: ERROR
+    fix: "acctest.CtResourceKey1"
+  - id: literal-ResourceKey2-string-test-constant
+    languages: [go]
+    message: Use the constant `acctest.CtResourceKey2` for the string literal "resourcekey2" in test files
+    paths:
+      include:
+        - "internal/service/**/*_test.go"
+    pattern: '"resourcekey2"'
+    severity: ERROR
+    fix: "acctest.CtResourceKey2"
+  - id: literal-ResourceOwner-string-test-constant
+    languages: [go]
+    message: Use the constant `acctest.CtResourceOwner` for the string literal "resource_owner" in test files
+    paths:
+      include:
+        - "internal/service/**/*_test.go"
+    pattern: '"resource_owner"'
+    severity: ERROR
+    fix: "acctest.CtResourceOwner"
+  - id: literal-ResourceTags-string-test-constant
+    languages: [go]
+    message: Use the constant `acctest.CtResourceTags` for the string literal "resource_tags" in test files
+    paths:
+      include:
+        - "internal/service/**/*_test.go"
+    pattern: '"resource_tags"'
+    severity: ERROR
+    fix: "acctest.CtResourceTags"
   - id: literal-ResourceValue1-string-test-constant
     languages: [go]
     message: Use the constant `acctest.CtResourceValue1` for the string literal "resourcevalue1" in test files
@@ -138,6 +246,15 @@ rules:
     pattern: '"resourcevalue1"'
     severity: ERROR
     fix: "acctest.CtResourceValue1"
+  - id: literal-ResourceValue1Updated-string-test-constant
+    languages: [go]
+    message: Use the constant `acctest.CtResourceValue1Updated` for the string literal "resourcevalue1updated" in test files
+    paths:
+      include:
+        - "internal/service/**/*_test.go"
+    pattern: '"resourcevalue1updated"'
+    severity: ERROR
+    fix: "acctest.CtResourceValue1Updated"
   - id: literal-ResourceValue2-string-test-constant
     languages: [go]
     message: Use the constant `acctest.CtResourceValue2` for the string literal "resourcevalue2" in test files
@@ -192,6 +309,15 @@ rules:
     pattern: '"tags.%"'
     severity: ERROR
     fix: "acctest.CtTagsPercent"
+  - id: literal-True-string-test-constant
+    languages: [go]
+    message: Use the constant `acctest.CtTrue` for the string literal "true" in test files
+    paths:
+      include:
+        - "internal/service/**/*_test.go"
+    pattern: '"true"'
+    severity: ERROR
+    fix: "acctest.CtTrue"
   - id: literal-TrueCaps-string-test-constant
     languages: [go]
     message: Use the constant `acctest.CtTrueCaps` for the string literal "TRUE" in test files

.ci/providerlint/go.mod

@@ -3,7 +3,7 @@ module github.com/hashicorp/terraform-provider-aws/ci/providerlint
 go 1.22
 
 require (
-	github.com/aws/aws-sdk-go v1.53.6
+	github.com/aws/aws-sdk-go v1.53.9
 	github.com/bflad/tfproviderlint v0.29.0
 	github.com/hashicorp/terraform-plugin-sdk/v2 v2.34.0
 	golang.org/x/tools v0.13.0

.ci/providerlint/go.sum

@@ -9,8 +9,8 @@ github.com/agext/levenshtein v1.2.2/go.mod h1:JEDfjyjHDjOF/1e4FlBE/PkbqA9OfWu2ki
 github.com/apparentlymart/go-textseg/v12 v12.0.0/go.mod h1:S/4uRK2UtaQttw1GenVJEynmyUenKwP++x/+DdGV/Ec=
 github.com/apparentlymart/go-textseg/v15 v15.0.0 h1:uYvfpb3DyLSCGWnctWKGj857c6ew1u1fNQOlOtuGxQY=
 github.com/apparentlymart/go-textseg/v15 v15.0.0/go.mod h1:K8XmNZdhEBkdlyDdvbmmsvpAG721bKi0joRfFdHIWJ4=
-github.com/aws/aws-sdk-go v1.53.6 h1:1/MYh/VmxdJu7v2bwvDA2JS30UI7bg62QYgQ7KxMa/Q=
-github.com/aws/aws-sdk-go v1.53.6/go.mod h1:LF8svs817+Nz+DmiMQKTO3ubZ/6IaTpq3TjupRn3Eqk=
+github.com/aws/aws-sdk-go v1.53.9 h1:6oipls9+L+l2Me5rklqlX3xGWNWGcMinY3F69q9Q+Cg=
+github.com/aws/aws-sdk-go v1.53.9/go.mod h1:LF8svs817+Nz+DmiMQKTO3ubZ/6IaTpq3TjupRn3Eqk=
 github.com/bflad/gopaniccheck v0.1.0 h1:tJftp+bv42ouERmUMWLoUn/5bi/iQZjHPznM00cP/bU=
 github.com/bflad/gopaniccheck v0.1.0/go.mod h1:ZCj2vSr7EqVeDaqVsWN4n2MwdROx1YL+LFo47TSWtsA=
 github.com/bflad/tfproviderlint v0.29.0 h1:zxKYAAM6IZ4ace1a3LX+uzMRIMP8L+iOtEc+FP2Yoow=

.ci/providerlint/vendor/modules.txt

@@ -28,7 +28,7 @@ github.com/agext/levenshtein
 # github.com/apparentlymart/go-textseg/v15 v15.0.0
 ## explicit; go 1.16
 github.com/apparentlymart/go-textseg/v15/textseg
-# github.com/aws/aws-sdk-go v1.53.6
+# github.com/aws/aws-sdk-go v1.53.9
 ## explicit; go 1.19
 github.com/aws/aws-sdk-go/aws/awserr
 github.com/aws/aws-sdk-go/aws/endpoints