Merge pull request #31394 from hashicorp/td-createTags-inspector

Tech debt: Reduce tags boilerplate code - Use `createTags`; Inspector
hashicorp · May 12, 2023 · b39fdfb · b39fdfb
2 parents 52ae8ed + fc84370
commit b39fdfb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/internal/service/inspector/assessment_template.go b/internal/service/inspector/assessment_template.go
@@ -108,7 +108,7 @@ func resourceAssessmentTemplateCreate(ctx context.Context, d *schema.ResourceDat
 
 	d.SetId(aws.StringValue(output.AssessmentTemplateArn))
 
-	if err := updateTags(ctx, conn, d.Id(), nil, KeyValueTags(ctx, GetTagsIn(ctx))); err != nil {
+	if err := createTags(ctx, conn, d.Id(), GetTagsIn(ctx)); err != nil {
 		return sdkdiag.AppendErrorf(diags, "setting Inspector Classic Assessment Template (%s) tags: %s", d.Id(), err)
 	}
 

diff --git a/internal/service/inspector/tags.go b/internal/service/inspector/tags.go
@@ -49,6 +49,14 @@ func updateTags(ctx context.Context, conn inspectoriface.InspectorAPI, identifie
 	return nil
 }
 
+func createTags(ctx context.Context, conn inspectoriface.InspectorAPI, identifier string, tags []*inspector.Tag) error {
+	if len(tags) == 0 {
+		return nil
+	}
+
+	return updateTags(ctx, conn, identifier, nil, KeyValueTags(ctx, tags))
+}
+
 // UpdateTags updates Inspector Classic service tags.
 // It is called from outside this package.
 func (p *servicePackage) UpdateTags(ctx context.Context, meta any, identifier string, oldTags, newTags any) error {