Merge branch 'main' of github.com:hashicorp/terraform-provider-aws in…

…to 28665

.changelog/19943.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_secretsmanager_secret_version: Fix `InvalidParameterException: The parameter RemoveFromVersionId can't be empty. Staging label AWSCURRENT is currently attached to version ..., so you must explicitly reference that version in RemoveFromVersionId` errors when a secret is updated outside Terraform
+```

.changelog/32205.txt

@@ -0,0 +1,3 @@
+```release-note:new-resource
+aws_verifiedpermissions_policy_template
+```

.changelog/32484.txt

@@ -0,0 +1,3 @@
+```release-note:new-data-source
+aws_msk_bootstrap_brokers
+```

.changelog/34399.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+data-source/aws_msk_configuration: Remove `name` length validation
+```

.changelog/34738.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_ram_principal_association: Fix `reading RAM Resource Share (...) Principal Association (...): couldn't find resource (21 retries)` errors when a high number of principals are associated with a resource share
+```

.changelog/34841.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_codepipeline: Add `pipeline_type` argument and `variable` configuration block
+```

.changelog/34891.txt

@@ -0,0 +1,3 @@
+```release-note:new-resource
+aws_lexv2models_intent
+```

.changelog/34955.txt

@@ -0,0 +1,7 @@
+```release-note:enhancement
+resource/aws_efs_replication_configuration: Increase Create timeout to 20 minutes
+```
+
+```release-note:enhancement
+resource/aws_efs_replication_configuration: Mark `destination.file_system_id` as Optional, enabling [EFS replication fallback](https://docs.aws.amazon.com/efs/latest/ug/replication-use-cases.html#replicate-existing-destination)
+```

.changelog/34985.txt

@@ -0,0 +1,7 @@
+```release-note:enhancement
+resource/aws_neptune_cluster: Add `storage_type` argument
+```
+
+```release-note:enhancement
+resource/aws_neptune_cluster_instance: Add `storage_type` attribute
+```

.changelog/34994.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_backup_plan: Add `rule.lifecycle.opt_in_to_archive_for_supported_resources` and `rule.copy_action.lifecycle.opt_in_to_archive_for_supported_resources` and arguments
+```

.changelog/35105.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_secretsmanager_secret_rotation: Add `rotate_immediately` argument
+```

.changelog/35117.txt

@@ -0,0 +1,7 @@
+```release-note:enhancement
+data-source/aws_secretsmanager_secret: Add `created_date` and `last_changed_date` attributes
+```
+
+```release-note:enhancement
+data-source/aws_secretsmanager_secret_version: Add `created_date` attribute
+```

.changelog/35129.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_transfer_server: Add `TransferSecurityPolicy-PQ-SSH-Experimental-2023-04` and `TransferSecurityPolicy-PQ-SSH-FIPS-Experimental-2023-04` as valid values for `security_policy_name`
+```

.changelog/35173.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_appstream_fleet: Increase `idle_disconnect_timeout_in_seconds` max value for validation to 360000
+```

.changelog/35195.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_glue_catalog_database: Properly handle out-of-band resource deletion
+```

.changelog/35206.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_finspace_kx_scaling_group: Increase default create, delete timeouts to 4 hours
+```

.changelog/35207.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_finspace_kx_dataview: Increase default create, update, and delete timeouts to 4 hours
+```

.changelog/35211.txt

@@ -0,0 +1,3 @@
+```release-note:new-resource
+aws_ebs_fast_snapshot_restore
+```

.changelog/35215.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_appflow_flow: Add `destination_connector_properties.s3.s3_output_format_config.target_file_size` argument
+```

.changelog/35223.txt

@@ -0,0 +1,19 @@
+```release-note:bug
+resource/aws_s3_object: Remove any leading `./` from `key` to maintain AWS SDK for Go v1 (pre-v5.17.0) compatibility
+```
+
+```release-note:bug
+data-source/aws_s3_object: Remove any leading `./` from `key` to maintain AWS SDK for Go v1 (pre-v5.17.0) compatibility
+```
+
+```release-note:bug
+data-source/aws_s3_bucket_object: Remove any leading `./` from `key` to maintain AWS SDK for Go v1 (pre-v5.17.0) compatibility
+```
+
+```release-note:bug
+resource/aws_s3_object_copy: Remove any leading `./` from `key` to maintain AWS SDK for Go v1 (pre-v5.17.0) compatibility
+```
+
+```release-note:bug
+resource/aws_s3_bucket_object: Remove any leading `./` from `key` to maintain AWS SDK for Go v1 (pre-v5.17.0) compatibility
+```

.changelog/35225.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_iot_indexing_configuration: Correct plan-time validation of `thing_indexing_configuration.filter.named_shadow_names`
+```

.changelog/35228.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_lb: Fix `ValidationError: Attributes cannot be empty` errors
+```

.changelog/35234.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_iot_ca_certificate: Change `registration_config.role_arn` from `TypeBool` to `TypeString`, fixing `Inappropriate value for attribute "role_arn": a bool is required` errors
+```

.changelog/35254.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_fis_experiment_template: Fix validation error when not using `target.resource_arns` or `target.resource_tag` attributes.
+```

.changelog/35265.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_mq_broker: Fix `interface conversion: interface {} is *schema.Set, not []string` panic
+```

.changelog/35269.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+data-source/aws_ecr_image: Fix error when `most_recent` is not also `latest`
+```

.changelog/35282.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_datasync_task: Allow `schedule` to be removed successfully
+```

.changelog/35284.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_lakeformation_resource: Add `use_service_linked_role` argument
+```

.changelog/35289.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_lb_listener: Fix `ValidationError: Mutual Authentication mode passthrough does not support ignoring certificate expiry` errors when `mutual_authentication.mode` is set to `passthrough`
+```

.ci/.golangci2.yml

@@ -173,6 +173,7 @@ linters-settings:
           - argument
         ignored-functions:
           # AWS Go SDK
+          - aws.Int32
           - aws.Int64
           - request.ConstantWaiterDelay
           - request.WithWaiterMaxAttempts

.ci/.semgrep-service-name0.yml

@@ -3695,3 +3695,62 @@ rules:
             - pattern-not-regex: "^TestAccConfigService"
             - pattern-regex: ^TestAcc.*
     severity: WARNING
+  - id: configservice-in-const-name
+    languages:
+      - go
+    message: Do not use "ConfigService" in const name inside configservice package
+    paths:
+      include:
+        - internal/service/configservice
+    patterns:
+      - pattern: const $NAME = ...
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-regex: "(?i)ConfigService"
+    severity: WARNING
+  - id: configservice-in-var-name
+    languages:
+      - go
+    message: Do not use "ConfigService" in var name inside configservice package
+    paths:
+      include:
+        - internal/service/configservice
+    patterns:
+      - pattern: var $NAME = ...
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-regex: "(?i)ConfigService"
+    severity: WARNING
+  - id: connect-in-func-name
+    languages:
+      - go
+    message: Do not use "Connect" in func name inside connect package
+    paths:
+      include:
+        - internal/service/connect
+    patterns:
+      - pattern: func $NAME( ... ) { ... }
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-regex: "(?i)Connect"
+            - pattern-not-regex: .*uickConnect.*
+            - pattern-not-regex: ^TestAcc.*
+    severity: WARNING
+  - id: connect-in-test-name
+    languages:
+      - go
+    message: Include "Connect" in test name
+    paths:
+      include:
+        - internal/service/connect/*_test.go
+    patterns:
+      - pattern: func $NAME( ... ) { ... }
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-not-regex: "^TestAccConnect"
+            - pattern-regex: ^TestAcc.*
+    severity: WARNING