Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: Replace 'FloatAtLeast' and 'validateStringNotMatch' with terraform-plugin-sdk 'validation.FloatAtLeast' and 'validation.StringDoesNotMatch' #11034

Closed
4 tasks done
ewbankkit opened this issue Nov 27, 2019 · 2 comments · Fixed by #12207
Assignees
Labels
technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Nov 27, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

After the merging of #10960 we can now replace

from terraform-plugin-sdk.

References

Similar:

FloatAtLeast()

  • aws/resource_aws_sagemaker_endpoint_configuration.go

validateStringNotMatch()

  • aws/resource_aws_dax_cluster.go
  • aws/resource_aws_elasticache_cluster.go
  • aws/resource_aws_elasticache_replication_group.go
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 27, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 27, 2019
@bflad bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Jan 31, 2020
@bflad bflad self-assigned this Mar 3, 2020
@bflad bflad added this to the v2.52.0 milestone Mar 3, 2020
@ghost
Copy link

ghost commented Mar 6, 2020

This has been released in version 2.52.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
2 participants