Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: Replace 'validateAny' and 'validateIntegerInSlice' with upstream 'validation.Any' and 'validation.IntInSlice' #7906

Closed
ewbankkit opened this issue Mar 12, 2019 · 2 comments · Fixed by #8479
Closed

Tech debt: Replace 'validateAny' and 'validateIntegerInSlice' with upstream 'validation.Any' and 'validation.IntInSlice' #7906

ewbankkit opened this issue Mar 12, 2019 · 2 comments · Fixed by #8479
Labels
good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. provider Pertains to the provider itself, rather than any interaction with AWS. technical-debt Addresses areas of the codebase that need refactoring or redesign.

Comments

@ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

After the merging of #7874 we can now replace validateAny() https://github.com/terraform-providers/terraform-provider-aws/blob/97596eefb71281379b3f80119556051bf3374d1a/aws/validators.go#L27-L41 with validation.Any() https://github.com/terraform-providers/terraform-provider-aws/blob/97596eefb71281379b3f80119556051bf3374d1a/vendor/github.com/hashicorp/terraform/helper/validation/validation.go#L33-L47 and validateIntegerInSlice() https://github.com/terraform-providers/terraform-provider-aws/blob/97596eefb71281379b3f80119556051bf3374d1a/aws/validators.go#L593-L608 with validators.IntInSlice() https://github.com/terraform-providers/terraform-provider-aws/blob/97596eefb71281379b3f80119556051bf3374d1a/vendor/github.com/hashicorp/terraform/helper/validation/validation.go#L108-L125.

Related:
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 12, 2019
@bflad bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. provider Pertains to the provider itself, rather than any interaction with AWS. and removed enhancement Requests to existing resources that expand the functionality or scope. labels Mar 13, 2019
@bflad bflad added the good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. label Apr 24, 2019
@bflad bflad mentioned this issue Apr 24, 2019
Merged
@ewbankkit ewbankkit mentioned this issue Apr 24, 2019
Closed
@richardjennings richardjennings mentioned this issue Apr 29, 2019
Merged
@richardjennings
Copy link
Contributor

I have opened a PR #8479

nywilken pushed a commit that referenced this issue May 2, 2019
@richardjennings @nywilken
Tech debt: Replace 'validateAny' and 'validateIntegerInSlice' with up…
9e27f5b 
…stream 'validation.Any' and 'validation.IntInSlice' (#8479)

* After the merging of #7874 we can now replace validateAny() with with validation.Any()
and validateIntegerInSlice() with validators.IntInSlice()

*  #7906 inline values to aid readability
@ewbankkit ewbankkit mentioned this issue Nov 27, 2019
Closed
4 tasks
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. provider Pertains to the provider itself, rather than any interaction with AWS. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
No milestone
3 participants
@bflad @richardjennings @ewbankkit