Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Multiple improvements to aws_ssm_patch_baseline #1257

Closed
sfrode opened this issue Jul 27, 2017 · 7 comments · Fixed by #1260
Closed

FR: Multiple improvements to aws_ssm_patch_baseline #1257

sfrode opened this issue Jul 27, 2017 · 7 comments · Fixed by #1260
Labels
new-resource Introduces a new resource.

Comments

@sfrode
Copy link

sfrode commented Jul 27, 2017

The aws_ssm_patch_baseline seems to be needing a few updates:

  1. aws_ssm_patch_baseline is missing support for the "OperatingSystem" parameter, leading to a situation where the API defaults to Windows as the only supported OS.

  2. Lack of support for the "ApprovedPatchesComplianceLevel" parameter

  3. There is no support for updating resources, leading to a new patch baseline with every single change.
@stack72
Copy link
Contributor

stack72 commented Jul 27, 2017 •
edited

Hi @sfrode

PR in progress now :) It will add the new features - I can circle back and add all of the updates later. Can you open a new issue with all of the resources in SSM that you believe need an Update rather than ForceNew?

Paul

stack72 added a commit to stack72/terraform-provider-aws that referenced this issue Jul 27, 2017
@stack72
resource/aws_ssm_patch_baseline: Update support for Operating System
38dfc58 
Fixes: hashicorp#1257

I am going to add `operating_system` and
`approved_patches_compliance_level` only in this PR - I believe that an
overhaul of SSM to remove ForceNew from all of SSM resources can be
added in a follow up PR if that suffices

```
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMPatchBaseline'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSSMPatchBaseline -timeout 120m
=== RUN   TestAccAWSSSMPatchBaseline_basic
--- PASS: TestAccAWSSSMPatchBaseline_basic (43.22s)
=== RUN   TestAccAWSSSMPatchBaselineWithOperatingSystem
--- PASS: TestAccAWSSSMPatchBaselineWithOperatingSystem (23.45s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	66.691s
```
@stack72 stack72 mentioned this issue Jul 27, 2017
Merged
@sfrode
Copy link
Author

sfrode commented Jul 27, 2017

@stack72 - thanks a lot! This was awsomely fast!

I'll follow up the lack of support for Updates in another ticket as it seems to be a common theme amongst the SSM resources.

Thanks a lot!

@stack72
Copy link
Contributor

stack72 commented Jul 27, 2017

@sfrode no worries at all - as long as you can agree that we can drop 3 for the need to close this PR then i am happy to push forward :)

I think the separate task of adding updates to all the required resources is the right thing

@sfrode
Copy link
Author

sfrode commented Jul 27, 2017

Agreed

@stack72
Copy link
Contributor

stack72 commented Jul 27, 2017

Awesome!

@radeksimko radeksimko added the new-resource Introduces a new resource. label Jul 28, 2017
@stack72
Copy link
Contributor

stack72 commented Jul 31, 2017

Ping @sfrode to open the issue for SSM resource updates ;)

@sfrode sfrode mentioned this issue Aug 1, 2017
Closed
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
new-resource Introduces a new resource.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resource/aws_ssm_patch_baseline: Update support for Operating System stack72/terraform-provider-aws
3 participants
@stack72 @radeksimko @sfrode