Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitbucket Submodule support for aws_codebuild_project #13588

Closed
supernovel opened this issue Jun 3, 2020 · 2 comments · Fixed by #18843
Closed

Bitbucket Submodule support for aws_codebuild_project #13588

supernovel opened this issue Jun 3, 2020 · 2 comments · Fixed by #18843
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service.
Milestone

Comments

@supernovel
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

  • When we build our project code through Codebuild, it’s necessary fetching a git submodule included there. But there is no feature for Bitbucket in the provider.
  • It is required to add the code for Bitbucket because AWS documentation shows fetching a git submodule in Bitbucket is provided.

https://docs.aws.amazon.com/codebuild/latest/userguide/create-project.html
gitSubmodulesConfig: Optional. Information about the Git submodules configuration. Used with CodeCommit, GitHub, GitHub Enterprise, and Bitbucket only. Set fetchSubmodules to true if you want to include the Git submodules in your repository. Git submodules that are included must be configured as HTTPS.

New or Affected Resource(s)

  • resource_aws_codebuild_project.go

https://github.com/terraform-providers/terraform-provider-aws/blob/accd2d42ac82c126fb1967677f4b82f0d8824715/aws/resource_aws_codebuild_project.go#L1047-L1060

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

resource "aws_codebuild_project" "example" {
  source {
    type = "BITBUCKET"

    git_submodules_config {
      fetch_submodules = true
    }
  }
}

References

@supernovel supernovel added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 3, 2020
@ghost ghost added the service/codebuild Issues and PRs that pertain to the codebuild service. label Jun 3, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 3, 2020
@DrFaust92 DrFaust92 removed the needs-triage Waiting for first response or review from a maintainer. label Apr 14, 2021
@github-actions github-actions bot added this to the v3.38.0 milestone Apr 29, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service.
Projects
None yet
2 participants