Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_efs_mount_target: Terraform can not validate empty IPv4 address with 2.67.0 #13845

Closed
jamestenglish opened this issue Jun 19, 2020 · 6 comments · Fixed by #13958
Closed
Assignees
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/efs Issues and PRs that pertain to the efs service.
Milestone

Comments

@jamestenglish
Copy link

This was fixed in 2.66.0 but seems to have reemerged in 2.67.0
See: #13626

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 19, 2020
@ewbankkit ewbankkit added the service/ec2 Issues and PRs that pertain to the ec2 service. label Jun 25, 2020
@ewbankkit
Copy link
Contributor

@jamestenglish Thanks for raising this issue.
Could you please add an example configuration that exhibits the problem?

@ghost
Copy link

ghost commented Jun 25, 2020

It happens with this module https://github.com/cloudposse/terraform-aws-efs

Edit: more specifically with this resource type aws_efs_mount_target ip_address is optional

@bflad
Copy link
Contributor

bflad commented Jun 26, 2020

The Terraform module supports Terraform 0.12 syntax so it should be able to pass null properly into the ip_address argument without provider changes, however we will re-add support for "" to keep backwards compatibility with other Terraform 0.11 code and track the empty string validation removal as part of #13943

@bflad bflad added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/efs Issues and PRs that pertain to the efs service. and removed needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. labels Jun 26, 2020
@bflad bflad added this to the v2.69.0 milestone Jun 26, 2020
@bflad bflad self-assigned this Jun 26, 2020
@bflad bflad changed the title Terraform can not validate empty IPv4 address with 2.67.0 resource/aws_efs_mount_target: Terraform can not validate empty IPv4 address with 2.67.0 Jun 26, 2020
@bflad
Copy link
Contributor

bflad commented Jun 26, 2020

The validation regression fix for the aws_efs_mount_target resource has been merged and will release with version 2.69.0 of the Terraform AWS Provider, Thursday next week.

@ghost
Copy link

ghost commented Jul 3, 2020

This has been released in version 2.69.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/efs Issues and PRs that pertain to the efs service.
Projects
None yet
3 participants