Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AWS App Mesh Virtual Gateway #14169

Closed
completenovice opened this issue Jul 14, 2020 · 6 comments · Fixed by #15638
Closed

Add support for AWS App Mesh Virtual Gateway #14169

completenovice opened this issue Jul 14, 2020 · 6 comments · Fixed by #15638
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/appmesh Issues and PRs that pertain to the appmesh service.
Milestone

Comments

@completenovice
Copy link

completenovice commented Jul 14, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Allow the creation of an AWS App Mesh Virtual Gateway.

New or Affected Resource(s)

  • aws_appmesh_virtual_gateway
  • aws_appmesh_gateway_route

Potential Terraform Configuration

resource "aws_appmesh_virtual_gateway" "vgateway" {
  name      = "example-gateway"
  mesh_name = "mesh"

  spec {
    backendDefaults {
      clientPolicy {
        tls {
          enforce = false
        }
      }
    }

    listeners = [
      {
        port_mapping {
          port     = 80,
          protocol = "http",
        }
      }
    ]
  }
}

resource "aws_appmesh_gateway_route" {
  gateway_route_name   = "http_route"
  virtual_gateway_name = aws_appmesh_virtual_gateway.vgateway.name
  mesh_name            = "mesh"

  spec {
    http_route {
      action {
        target {
          virtual_service {
            virtual_service_name = "my-virtual-service"
          }
        }
      }
      match {
        prefix = "/"
      }
    }
  }
}

References

@completenovice completenovice added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 14, 2020
@ghost ghost added the service/appmesh Issues and PRs that pertain to the appmesh service. label Jul 14, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 14, 2020
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 14, 2020
@ewbankkit
Copy link
Contributor

@rmaskara
Copy link

rmaskara commented Oct 5, 2020

when are we planning take this up?

@ewbankkit
Copy link
Contributor

@rmaskara We are working through the backlog of AppMesh PRs, many of which were released last week and with #14361 at the last outstanding one. I will start work on this issue shortly.

@rmaskara
Copy link

rmaskara commented Oct 5, 2020

Thanks @ewbankkit . We are using the stuff that was released last week already. So, that was very helpful! Would you say that it would take about a couple of months to get it through development and PR approvals?

@ghost
Copy link

ghost commented Oct 15, 2020

This has been released in version 3.11.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/appmesh Issues and PRs that pertain to the appmesh service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants