AppMesh timeout configuration support #14361

ewbankkit · 2020-07-27T21:11:58Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Includes gRPC and HTTP/2 service support from #11669.

Release note for CHANGELOG:

resource/aws_appmesh_route: Add `timeout` configuration block to `grpc_route`, `http_route`, `http2_route` and `tcp_route` attributes.
resource/aws_appmesh_virtual_node: Add `timeout` configuration block to `listener` attribute.

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/Mesh
=== RUN   TestAccAWSAppmesh_serial/Mesh/basic
=== RUN   TestAccAWSAppmesh_serial/Mesh/egressFilter
=== RUN   TestAccAWSAppmesh_serial/Mesh/tags
=== RUN   TestAccAWSAppmesh_serial/Route
=== RUN   TestAccAWSAppmesh_serial/Route/grpcRoute
=== RUN   TestAccAWSAppmesh_serial/Route/http2Route
=== RUN   TestAccAWSAppmesh_serial/Route/routePriority
=== RUN   TestAccAWSAppmesh_serial/Route/tcpRoute
=== RUN   TestAccAWSAppmesh_serial/Route/tcpRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/grpcRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/http2RouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/httpHeader
=== RUN   TestAccAWSAppmesh_serial/Route/httpRetryPolicy
=== RUN   TestAccAWSAppmesh_serial/Route/httpRoute
=== RUN   TestAccAWSAppmesh_serial/Route/httpRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/logging
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualService
=== RUN   TestAccAWSAppmesh_serial/VirtualService/virtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualService/virtualRouter
=== RUN   TestAccAWSAppmesh_serial/VirtualService/tags
--- PASS: TestAccAWSAppmesh_serial (789.66s)
    --- PASS: TestAccAWSAppmesh_serial/Mesh (56.88s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/basic (11.27s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/egressFilter (21.39s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/tags (24.22s)
    --- PASS: TestAccAWSAppmesh_serial/Route (380.20s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRoute (38.38s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2Route (30.69s)
        --- PASS: TestAccAWSAppmesh_serial/Route/routePriority (27.80s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRoute (38.45s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRouteTimeout (27.64s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRouteTimeout (27.13s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2RouteTimeout (28.36s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpHeader (27.98s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRetryPolicy (28.10s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRoute (38.11s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRouteTimeout (27.95s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tags (39.61s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (210.49s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (32.23s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (14.13s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (95.00s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (23.19s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (22.88s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (23.05s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (53.06s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/basic (21.88s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/tags (31.18s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualService (89.03s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualNode (27.31s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualRouter (24.57s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/tags (37.15s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	789.712s

ewbankkit · 2020-07-30T21:35:20Z

Removed WIP.

ewbankkit · 2020-09-14T21:34:15Z

Rebased and fixed merge conflicts.
Re-ran acceptance tests:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/Mesh
=== RUN   TestAccAWSAppmesh_serial/Mesh/egressFilter
=== RUN   TestAccAWSAppmesh_serial/Mesh/tags
=== RUN   TestAccAWSAppmesh_serial/Mesh/basic
=== RUN   TestAccAWSAppmesh_serial/Route
=== RUN   TestAccAWSAppmesh_serial/Route/grpcRoute
=== RUN   TestAccAWSAppmesh_serial/Route/http2RouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/httpHeader
=== RUN   TestAccAWSAppmesh_serial/Route/tcpRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/tags
=== RUN   TestAccAWSAppmesh_serial/Route/grpcRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/http2Route
=== RUN   TestAccAWSAppmesh_serial/Route/httpRetryPolicy
=== RUN   TestAccAWSAppmesh_serial/Route/httpRoute
=== RUN   TestAccAWSAppmesh_serial/Route/httpRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/routePriority
=== RUN   TestAccAWSAppmesh_serial/Route/tcpRoute
=== RUN   TestAccAWSAppmesh_serial/VirtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/logging
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualService
=== RUN   TestAccAWSAppmesh_serial/VirtualService/virtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualService/virtualRouter
=== RUN   TestAccAWSAppmesh_serial/VirtualService/tags
--- PASS: TestAccAWSAppmesh_serial (1146.96s)
    --- PASS: TestAccAWSAppmesh_serial/Mesh (98.83s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/egressFilter (39.94s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/tags (42.48s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/basic (16.41s)
    --- PASS: TestAccAWSAppmesh_serial/Route (531.21s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRoute (54.92s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2RouteTimeout (39.03s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpHeader (38.48s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRouteTimeout (37.89s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tags (55.83s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRouteTimeout (38.00s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2Route (38.65s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRetryPolicy (39.38s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRoute (55.40s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRouteTimeout (38.97s)
        --- PASS: TestAccAWSAppmesh_serial/Route/routePriority (38.38s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRoute (56.25s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (278.40s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (33.86s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (33.93s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (35.61s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (49.14s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (19.31s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (106.55s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (112.07s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/basic (33.68s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/tags (78.38s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualService (126.44s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualNode (38.02s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualRouter (34.64s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/tags (53.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1146.999s

Acceptance test output: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/Route/grpcRoute' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route/grpcRoute -timeout 120m === RUN TestAccAWSAppmesh_serial === RUN TestAccAWSAppmesh_serial/Route === RUN TestAccAWSAppmesh_serial/Route/grpcRouteTimeout === RUN TestAccAWSAppmesh_serial/Route/grpcRoute === RUN TestAccAWSAppmesh_serial/VirtualRouter --- PASS: TestAccAWSAppmesh_serial (66.22s) --- PASS: TestAccAWSAppmesh_serial/Route (66.22s) --- PASS: TestAccAWSAppmesh_serial/Route/grpcRouteTimeout (27.92s) --- PASS: TestAccAWSAppmesh_serial/Route/grpcRoute (38.30s) --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (0.00s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 66.266s

Acceptance test output: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/Route/tcpRoute' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route/tcpRoute -timeout 120m === RUN TestAccAWSAppmesh_serial === RUN TestAccAWSAppmesh_serial/VirtualRouter === RUN TestAccAWSAppmesh_serial/Route === RUN TestAccAWSAppmesh_serial/Route/tcpRoute === RUN TestAccAWSAppmesh_serial/Route/tcpRouteTimeout --- PASS: TestAccAWSAppmesh_serial (64.63s) --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (0.00s) --- PASS: TestAccAWSAppmesh_serial/Route (64.63s) --- PASS: TestAccAWSAppmesh_serial/Route/tcpRoute (37.42s) --- PASS: TestAccAWSAppmesh_serial/Route/tcpRouteTimeout (27.20s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 64.686s

…upport. Acceptance test output: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/Route/httpRoute' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route/httpRoute -timeout 120m === RUN TestAccAWSAppmesh_serial === RUN TestAccAWSAppmesh_serial/Route === RUN TestAccAWSAppmesh_serial/Route/httpRoute === RUN TestAccAWSAppmesh_serial/Route/httpRouteTimeout === RUN TestAccAWSAppmesh_serial/VirtualRouter --- FAIL: TestAccAWSAppmesh_serial (40.30s) --- FAIL: TestAccAWSAppmesh_serial/Route (40.30s) --- FAIL: TestAccAWSAppmesh_serial/Route/httpRoute (12.26s) testing.go:684: Step 0 error: Check failed: Check 17/23 error: aws_appmesh_route.test: Attribute 'spec.0.http_route.0.timeout.#' expected "0", got "1" --- PASS: TestAccAWSAppmesh_serial/Route/httpRouteTimeout (28.03s) --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (0.00s) FAIL FAIL github.com/terraform-providers/terraform-provider-aws/aws 40.353s FAIL GNUmakefile:26: recipe for target 'testacc' failed make: *** [testacc] Error 1 $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/Route/http2Route' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route/http2Route -timeout 120m === RUN TestAccAWSAppmesh_serial === RUN TestAccAWSAppmesh_serial/Route === RUN TestAccAWSAppmesh_serial/Route/http2Route === RUN TestAccAWSAppmesh_serial/Route/http2RouteTimeout === RUN TestAccAWSAppmesh_serial/VirtualRouter --- FAIL: TestAccAWSAppmesh_serial (40.79s) --- FAIL: TestAccAWSAppmesh_serial/Route (40.79s) --- PASS: TestAccAWSAppmesh_serial/Route/http2Route (29.14s) --- FAIL: TestAccAWSAppmesh_serial/Route/http2RouteTimeout (11.65s) testing.go:684: Step 0 error: Check failed: Check 17/27 error: aws_appmesh_route.test: Attribute 'spec.0.http2_route.0.timeout.#' expected "1", got "0" --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (0.00s) FAIL FAIL github.com/terraform-providers/terraform-provider-aws/aws 40.836s FAIL GNUmakefile:26: recipe for target 'testacc' failed make: *** [testacc] Error 1

Acceptance test output: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/Route/httpRoute' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route/httpRoute -timeout 120m === RUN TestAccAWSAppmesh_serial === RUN TestAccAWSAppmesh_serial/Route === RUN TestAccAWSAppmesh_serial/Route/httpRouteTimeout === RUN TestAccAWSAppmesh_serial/Route/httpRoute === RUN TestAccAWSAppmesh_serial/VirtualRouter --- PASS: TestAccAWSAppmesh_serial (66.64s) --- PASS: TestAccAWSAppmesh_serial/Route (66.64s) --- PASS: TestAccAWSAppmesh_serial/Route/httpRouteTimeout (27.84s) --- PASS: TestAccAWSAppmesh_serial/Route/httpRoute (38.80s) --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (0.00s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 66.726s $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/Route/http2Route' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route/http2Route -timeout 120m === RUN TestAccAWSAppmesh_serial === RUN TestAccAWSAppmesh_serial/Route === RUN TestAccAWSAppmesh_serial/Route/http2RouteTimeout === RUN TestAccAWSAppmesh_serial/Route/http2Route === RUN TestAccAWSAppmesh_serial/VirtualRouter --- PASS: TestAccAWSAppmesh_serial (56.66s) --- PASS: TestAccAWSAppmesh_serial/Route (56.65s) --- PASS: TestAccAWSAppmesh_serial/Route/http2RouteTimeout (28.57s) --- PASS: TestAccAWSAppmesh_serial/Route/http2Route (28.08s) --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (0.00s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 56.732s

Acceptance test output: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/Route' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route -timeout 120m === RUN TestAccAWSAppmesh_serial === RUN TestAccAWSAppmesh_serial/Route === RUN TestAccAWSAppmesh_serial/Route/grpcRoute === RUN TestAccAWSAppmesh_serial/Route/grpcRouteTimeout === RUN TestAccAWSAppmesh_serial/Route/http2RouteTimeout === RUN TestAccAWSAppmesh_serial/Route/httpHeader === RUN TestAccAWSAppmesh_serial/Route/httpRoute === RUN TestAccAWSAppmesh_serial/Route/httpRouteTimeout === RUN TestAccAWSAppmesh_serial/Route/tcpRouteTimeout === RUN TestAccAWSAppmesh_serial/Route/tags === RUN TestAccAWSAppmesh_serial/Route/http2Route === RUN TestAccAWSAppmesh_serial/Route/httpRetryPolicy === RUN TestAccAWSAppmesh_serial/Route/routePriority === RUN TestAccAWSAppmesh_serial/Route/tcpRoute === RUN TestAccAWSAppmesh_serial/VirtualRouter === RUN TestAccAWSAppmesh_serial/VirtualRouter/basic === RUN TestAccAWSAppmesh_serial/VirtualRouter/tags --- PASS: TestAccAWSAppmesh_serial (433.25s) --- PASS: TestAccAWSAppmesh_serial/Route (379.45s) --- PASS: TestAccAWSAppmesh_serial/Route/grpcRoute (38.84s) --- PASS: TestAccAWSAppmesh_serial/Route/grpcRouteTimeout (27.86s) --- PASS: TestAccAWSAppmesh_serial/Route/http2RouteTimeout (27.77s) --- PASS: TestAccAWSAppmesh_serial/Route/httpHeader (28.29s) --- PASS: TestAccAWSAppmesh_serial/Route/httpRoute (38.87s) --- PASS: TestAccAWSAppmesh_serial/Route/httpRouteTimeout (28.38s) --- PASS: TestAccAWSAppmesh_serial/Route/tcpRouteTimeout (27.92s) --- PASS: TestAccAWSAppmesh_serial/Route/tags (39.58s) --- PASS: TestAccAWSAppmesh_serial/Route/http2Route (27.67s) --- PASS: TestAccAWSAppmesh_serial/Route/httpRetryPolicy (28.10s) --- PASS: TestAccAWSAppmesh_serial/Route/routePriority (27.74s) --- PASS: TestAccAWSAppmesh_serial/Route/tcpRoute (38.42s) --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (53.80s) --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/basic (22.61s) --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/tags (31.19s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 433.309s

Acceptance test output: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualNode' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualNode -timeout 120m === RUN TestAccAWSAppmesh_serial === RUN TestAccAWSAppmesh_serial/VirtualNode === RUN TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery === RUN TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks === RUN TestAccAWSAppmesh_serial/VirtualNode/logging === RUN TestAccAWSAppmesh_serial/VirtualNode/tags === RUN TestAccAWSAppmesh_serial/VirtualNode/basic --- PASS: TestAccAWSAppmesh_serial (191.43s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode (191.43s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (96.36s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (24.56s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (23.12s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (32.95s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (14.41s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 191.496s

…rTimeout'. Acceptance test output: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualNode/listenerTimeout' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualNode/listenerTimeout -timeout 120m === RUN TestAccAWSAppmesh_serial === RUN TestAccAWSAppmesh_serial/VirtualNode === RUN TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout --- PASS: TestAccAWSAppmesh_serial (23.16s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode (23.16s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (23.16s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 23.237s

r/aws_appmesh_route: Use '_Values()' (hashicorp#14601).

… to 0.12 syntax. r/aws_appmesh_route: Update resource testing and documentation to 0.12 syntax. Acceptance test output: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh -timeout 120m === RUN TestAccAWSAppmesh_serial === RUN TestAccAWSAppmesh_serial/Mesh === RUN TestAccAWSAppmesh_serial/Mesh/egressFilter === RUN TestAccAWSAppmesh_serial/Mesh/tags === RUN TestAccAWSAppmesh_serial/Mesh/basic === RUN TestAccAWSAppmesh_serial/Route === RUN TestAccAWSAppmesh_serial/Route/grpcRoute === RUN TestAccAWSAppmesh_serial/Route/http2RouteTimeout === RUN TestAccAWSAppmesh_serial/Route/httpHeader === RUN TestAccAWSAppmesh_serial/Route/tcpRouteTimeout === RUN TestAccAWSAppmesh_serial/Route/tags === RUN TestAccAWSAppmesh_serial/Route/grpcRouteTimeout === RUN TestAccAWSAppmesh_serial/Route/http2Route === RUN TestAccAWSAppmesh_serial/Route/httpRetryPolicy === RUN TestAccAWSAppmesh_serial/Route/httpRoute === RUN TestAccAWSAppmesh_serial/Route/httpRouteTimeout === RUN TestAccAWSAppmesh_serial/Route/routePriority === RUN TestAccAWSAppmesh_serial/Route/tcpRoute === RUN TestAccAWSAppmesh_serial/VirtualNode === RUN TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks === RUN TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout === RUN TestAccAWSAppmesh_serial/VirtualNode/logging === RUN TestAccAWSAppmesh_serial/VirtualNode/tags === RUN TestAccAWSAppmesh_serial/VirtualNode/basic === RUN TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery === RUN TestAccAWSAppmesh_serial/VirtualRouter === RUN TestAccAWSAppmesh_serial/VirtualRouter/basic === RUN TestAccAWSAppmesh_serial/VirtualRouter/tags === RUN TestAccAWSAppmesh_serial/VirtualService === RUN TestAccAWSAppmesh_serial/VirtualService/virtualNode === RUN TestAccAWSAppmesh_serial/VirtualService/virtualRouter === RUN TestAccAWSAppmesh_serial/VirtualService/tags --- PASS: TestAccAWSAppmesh_serial (1146.96s) --- PASS: TestAccAWSAppmesh_serial/Mesh (98.83s) --- PASS: TestAccAWSAppmesh_serial/Mesh/egressFilter (39.94s) --- PASS: TestAccAWSAppmesh_serial/Mesh/tags (42.48s) --- PASS: TestAccAWSAppmesh_serial/Mesh/basic (16.41s) --- PASS: TestAccAWSAppmesh_serial/Route (531.21s) --- PASS: TestAccAWSAppmesh_serial/Route/grpcRoute (54.92s) --- PASS: TestAccAWSAppmesh_serial/Route/http2RouteTimeout (39.03s) --- PASS: TestAccAWSAppmesh_serial/Route/httpHeader (38.48s) --- PASS: TestAccAWSAppmesh_serial/Route/tcpRouteTimeout (37.89s) --- PASS: TestAccAWSAppmesh_serial/Route/tags (55.83s) --- PASS: TestAccAWSAppmesh_serial/Route/grpcRouteTimeout (38.00s) --- PASS: TestAccAWSAppmesh_serial/Route/http2Route (38.65s) --- PASS: TestAccAWSAppmesh_serial/Route/httpRetryPolicy (39.38s) --- PASS: TestAccAWSAppmesh_serial/Route/httpRoute (55.40s) --- PASS: TestAccAWSAppmesh_serial/Route/httpRouteTimeout (38.97s) --- PASS: TestAccAWSAppmesh_serial/Route/routePriority (38.38s) --- PASS: TestAccAWSAppmesh_serial/Route/tcpRoute (56.25s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode (278.40s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (33.86s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (33.93s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (35.61s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (49.14s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (19.31s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (106.55s) --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (112.07s) --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/basic (33.68s) --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/tags (78.38s) --- PASS: TestAccAWSAppmesh_serial/VirtualService (126.44s) --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualNode (38.02s) --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualRouter (34.64s) --- PASS: TestAccAWSAppmesh_serial/VirtualService/tags (53.78s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 1146.999s

ewbankkit · 2020-10-01T18:28:41Z

Rebased and fixed merged conflicts.
Re-ran acceptance tests:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualNode'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualNode -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/VirtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/clientPolicyFile
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/tls
    resource_aws_appmesh_virtual_node_test.go:483: [INFO] Got non-empty plan, as expected
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendDefaults
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/clientPolicyAcm
    resource_aws_appmesh_virtual_node_test.go:691: [INFO] Got non-empty plan, as expected
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/logging
--- PASS: TestAccAWSAppmesh_serial (498.00s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (497.99s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (20.71s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/clientPolicyFile (34.61s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (35.03s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tls (84.81s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (49.75s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaults (34.64s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/clientPolicyAcm (62.12s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (106.78s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (35.10s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (34.45s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	498.039s
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/Route'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/Route
=== RUN   TestAccAWSAppmesh_serial/Route/http2Route
=== RUN   TestAccAWSAppmesh_serial/Route/http2RouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/tcpRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/tags
=== RUN   TestAccAWSAppmesh_serial/Route/httpRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/routePriority
=== RUN   TestAccAWSAppmesh_serial/Route/tcpRoute
=== RUN   TestAccAWSAppmesh_serial/Route/grpcRoute
=== RUN   TestAccAWSAppmesh_serial/Route/grpcRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/httpHeader
=== RUN   TestAccAWSAppmesh_serial/Route/httpRetryPolicy
=== RUN   TestAccAWSAppmesh_serial/Route/httpRoute
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/tags
--- PASS: TestAccAWSAppmesh_serial (633.54s)
    --- PASS: TestAccAWSAppmesh_serial/Route (549.31s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2Route (39.91s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2RouteTimeout (39.78s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRouteTimeout (39.98s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tags (58.84s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRouteTimeout (40.76s)
        --- PASS: TestAccAWSAppmesh_serial/Route/routePriority (39.69s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRoute (56.02s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRoute (57.34s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRouteTimeout (40.71s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpHeader (40.09s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRetryPolicy (39.89s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRoute (56.29s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (84.24s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/basic (35.37s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/tags (48.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	633.592s

DrFaust92

LGTM

--- PASS: TestAccAWSAppmesh_serial (3193.77s)
    --- PASS: TestAccAWSAppmesh_serial/Mesh (211.79s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/basic (41.55s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/egressFilter (79.99s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/tags (90.25s)
    --- PASS: TestAccAWSAppmesh_serial/Route (1225.12s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRouteTimeout (85.82s)
        --- PASS: TestAccAWSAppmesh_serial/Route/routePriority (86.43s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2Route (84.87s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpHeader (85.29s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2RouteTimeout (88.68s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRetryPolicy (91.03s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRoute (127.18s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRoute (136.64s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRouteTimeout (91.30s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tags (132.54s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRoute (124.33s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRouteTimeout (90.99s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (1190.23s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (163.58s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (78.17s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (85.75s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (51.57s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaults (89.93s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (95.56s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tls (212.24s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (175.05s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/clientPolicyAcm (145.72s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/clientPolicyFile (92.64s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (224.52s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/basic (94.50s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/tags (130.02s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualService (342.11s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualNode (104.32s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualRouter (93.72s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/tags (144.06s)

breathingdust · 2020-10-08T22:00:43Z

LGTM 🚀 Thanks @ewbankkit

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/VirtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/logging
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/clientPolicyAcm
    resource_aws_appmesh_virtual_node_test.go:691: [INFO] Got non-empty plan, as expected
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/clientPolicyFile
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/tls
    resource_aws_appmesh_virtual_node_test.go:483: [INFO] Got non-empty plan, as expected
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendDefaults
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualService
=== RUN   TestAccAWSAppmesh_serial/VirtualService/virtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualService/virtualRouter
=== RUN   TestAccAWSAppmesh_serial/VirtualService/tags
=== RUN   TestAccAWSAppmesh_serial/Mesh
=== RUN   TestAccAWSAppmesh_serial/Mesh/basic
=== RUN   TestAccAWSAppmesh_serial/Mesh/egressFilter
=== RUN   TestAccAWSAppmesh_serial/Mesh/tags
=== RUN   TestAccAWSAppmesh_serial/Route
=== RUN   TestAccAWSAppmesh_serial/Route/httpRetryPolicy
=== RUN   TestAccAWSAppmesh_serial/Route/httpRoute
=== RUN   TestAccAWSAppmesh_serial/Route/httpRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/tcpRoute
=== RUN   TestAccAWSAppmesh_serial/Route/tags
=== RUN   TestAccAWSAppmesh_serial/Route/grpcRoute
=== RUN   TestAccAWSAppmesh_serial/Route/grpcRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/http2Route
=== RUN   TestAccAWSAppmesh_serial/Route/http2RouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/httpHeader
=== RUN   TestAccAWSAppmesh_serial/Route/routePriority
=== RUN   TestAccAWSAppmesh_serial/Route/tcpRouteTimeout
--- PASS: TestAccAWSAppmesh_serial (1108.52s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (456.63s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (118.01s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (27.38s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (14.88s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/clientPolicyAcm (73.48s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/clientPolicyFile (30.16s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (26.63s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (26.78s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tls (71.24s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (41.55s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaults (26.52s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (65.05s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/basic (27.25s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/tags (37.80s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualService (99.55s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualNode (28.25s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualRouter (28.54s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/tags (42.77s)
    --- PASS: TestAccAWSAppmesh_serial/Mesh (84.62s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/basic (13.80s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/egressFilter (34.96s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/tags (35.85s)
    --- PASS: TestAccAWSAppmesh_serial/Route (402.68s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRetryPolicy (29.75s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRoute (41.09s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRouteTimeout (29.05s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRoute (41.82s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tags (43.94s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRoute (40.95s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRouteTimeout (28.36s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2Route (31.27s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2RouteTimeout (29.88s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpHeader (29.01s)
        --- PASS: TestAccAWSAppmesh_serial/Route/routePriority (29.79s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRouteTimeout (27.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1109.978s

ghost · 2020-10-09T16:18:26Z

This has been released in version 3.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-11-08T17:10:37Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ewbankkit requested a review from a team July 27, 2020 21:11

ewbankkit force-pushed the f-appmesh-timeout-configuration branch 2 times, most recently from 91b96fb to 45ea5d7 Compare July 29, 2020 22:37

ewbankkit changed the title ~~[WIP] AppMesh timeout configuration support~~ AppMesh timeout configuration support Jul 30, 2020

ewbankkit mentioned this pull request Aug 23, 2020

Update AppMesh resource acceptance tests to 0.12 syntax #14795

Merged

ewbankkit force-pushed the f-appmesh-timeout-configuration branch from ff9058d to c8723ed Compare September 14, 2020 21:33

ewbankkit added 16 commits October 1, 2020 13:20

r/aws_appmesh_route: Add support for retry policies.

b5d8206

r/aws_appmesh_route: Add support for retry policies.

7ec8be0

r/aws_appmesh_route: Support gRPC and HTTP/2 services.

9120d0a

r/aws_appmesh_route: Support gRPC and HTTP/2 services.

e64113e

r/aws_appmesh_virtual_router: Test gRPC and HTTP/2 listener protocols.

9b7b246

Fix compilation errors after rebase.

b790b3b

r/aws_appmesh_virtual_node: Use '_Values()' (hashicorp#14601).

0367605

r/aws_appmesh_route: Use '_Values()' (hashicorp#14601).

Remove duplicate example in aws_appmesh_route documentation.

d384377

ewbankkit force-pushed the f-appmesh-timeout-configuration branch 2 times, most recently from 9cc6140 to de67f77 Compare October 1, 2020 18:16

Fixes after rebase.

c14869d

ewbankkit force-pushed the f-appmesh-timeout-configuration branch from de67f77 to c14869d Compare October 1, 2020 20:25

ewbankkit mentioned this pull request Oct 5, 2020

Add support for AWS App Mesh Virtual Gateway #14169

Closed

DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 8, 2020

DrFaust92 approved these changes Oct 8, 2020

View reviewed changes

breathingdust added this to the v3.10.0 milestone Oct 8, 2020

breathingdust merged commit bb61d28 into hashicorp:master Oct 8, 2020

breathingdust added a commit that referenced this pull request Oct 8, 2020

Update CHANGELOG.md for #14361

1c9472b

ewbankkit deleted the f-appmesh-timeout-configuration branch October 9, 2020 13:00

This was referenced Oct 28, 2020

tests/provider: Add PreChecks (AppMesh) #15886

Merged

tests/provider: Missing PreChecks (AppMesh) #15888

Closed

ghost locked as resolved and limited conversation to collaborators Nov 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AppMesh timeout configuration support #14361

AppMesh timeout configuration support #14361

ewbankkit commented Jul 27, 2020 •

edited

ewbankkit commented Jul 30, 2020

ewbankkit commented Sep 14, 2020

ewbankkit commented Oct 1, 2020 •

edited

DrFaust92 left a comment

breathingdust commented Oct 8, 2020

ghost commented Oct 9, 2020

ghost commented Nov 8, 2020

AppMesh timeout configuration support #14361

AppMesh timeout configuration support #14361

Conversation

ewbankkit commented Jul 27, 2020 • edited

Community Note

ewbankkit commented Jul 30, 2020

ewbankkit commented Sep 14, 2020

ewbankkit commented Oct 1, 2020 • edited

DrFaust92 left a comment

Choose a reason for hiding this comment

breathingdust commented Oct 8, 2020

ghost commented Oct 9, 2020

ghost commented Nov 8, 2020

ewbankkit commented Jul 27, 2020 •

edited

ewbankkit commented Oct 1, 2020 •

edited