Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_cognito_identity_pool: openid_connect_provider_arns Showing Ordering Differences #15176

Closed
bflad opened this issue Sep 16, 2020 · 2 comments · Fixed by #15178
Closed
Assignees
Labels
bug Addresses a defect in current functionality. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Milestone

Comments

@bflad
Copy link
Member

bflad commented Sep 16, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Noticed by this consistently failing acceptance test:

=== CONT  TestAccAWSCognitoIdentityPool_openidConnectProviderArns
TestAccAWSCognitoIdentityPool_openidConnectProviderArns: resource_aws_cognito_identity_pool_test.go:99: After applying this test step, the plan was not empty.
stdout:
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# aws_cognito_identity_pool.main will be updated in-place
~ resource "aws_cognito_identity_pool" "main" {
allow_unauthenticated_identities = false
arn                              = "arn:aws:cognito-identity:us-west-2:*******:identitypool/us-west-2:29818d19-ab3c-40d5-b3cb-13ec6176ee24"
id                               = "us-west-2:29818d19-ab3c-40d5-b3cb-13ec6176ee24"
identity_pool_name               = "identity pool o9se4jvj2s"
~ openid_connect_provider_arns     = [
- "arn:aws:iam::123456789012:oidc-provider/bar.example.com",
"arn:aws:iam::123456789012:oidc-provider/foo.example.com",
+ "arn:aws:iam::123456789012:oidc-provider/bar.example.com",
]
saml_provider_arns               = []
supported_login_providers        = {}
tags                             = {}
}
Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccAWSCognitoIdentityPool_openidConnectProviderArns (107.41s)

The API is returning results in a non-deterministic manner while the resource attribute is declared as an ordered list. As long as the submission ordering is not important, the attribute can be switched to TypeSet to fix this difference handling.

Affected Resource(s)

  • aws_cognito_identity_pool

References

@bflad bflad added bug Addresses a defect in current functionality. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cognito labels Sep 16, 2020
@bflad bflad added this to the Roadmap milestone Sep 16, 2020
@bflad bflad self-assigned this Sep 16, 2020
bflad added a commit that referenced this issue Sep 16, 2020
…openid_connect_provider_arns argument

Reference: #15176

Output from acceptance testing:

```
--- PASS: TestAccAWSCognitoIdentityPool_basic (24.04s)
--- PASS: TestAccAWSCognitoIdentityPool_supportedLoginProviders (31.68s)
--- PASS: TestAccAWSCognitoIdentityPool_cognitoIdentityProviders (32.20s)
--- PASS: TestAccAWSCognitoIdentityPool_tags (33.05s)
--- PASS: TestAccAWSCognitoIdentityPool_openidConnectProviderArns (33.34s)
--- PASS: TestAccAWSCognitoIdentityPool_samlProviderArns (37.66s)
```
@bflad bflad modified the milestones: Roadmap, v3.7.0 Sep 17, 2020
bflad added a commit that referenced this issue Sep 17, 2020
…openid_connect_provider_arns argument (#15178)

Reference: #15176

Output from acceptance testing:

```
--- PASS: TestAccAWSCognitoIdentityPool_basic (24.04s)
--- PASS: TestAccAWSCognitoIdentityPool_supportedLoginProviders (31.68s)
--- PASS: TestAccAWSCognitoIdentityPool_cognitoIdentityProviders (32.20s)
--- PASS: TestAccAWSCognitoIdentityPool_tags (33.05s)
--- PASS: TestAccAWSCognitoIdentityPool_openidConnectProviderArns (33.34s)
--- PASS: TestAccAWSCognitoIdentityPool_samlProviderArns (37.66s)
```
@ghost
Copy link

ghost commented Sep 17, 2020

This has been released in version 3.7.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
1 participant