Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeguru profiling group resource #16768

Closed
taylora433 opened this issue Dec 15, 2020 · 9 comments · Fixed by #34672
Closed

Codeguru profiling group resource #16768

taylora433 opened this issue Dec 15, 2020 · 9 comments · Fixed by #34672
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/codeguruprofiler Issues and PRs that pertain to the codeguruprofiler service.
Milestone

Comments

@taylora433
Copy link

taylora433 commented Dec 15, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Resource for codeguru profiler is missing.

New or Affected Resource(s)

  • aws_codeguruprofiler_profiling_group

Will also need to attach permissions to the profiling group, unsure if this would be the same resource or another resource, as you attach them after creation.

Potential Terraform Configuration

resource "aws_codeguruprofiler_profiling_group" "default" {
  name = "name"
  compute_platform = "other|lambda"
  tags = {tag1 = val1}
}

References

@taylora433 taylora433 added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 15, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 15, 2020
@gdavison gdavison added new-resource Introduces a new resource. service/codeguruprofiler Issues and PRs that pertain to the codeguruprofiler service. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 17, 2020
@gdavison
Copy link
Contributor

Thanks for the issue, @taylora433. To match with our naming conventions (defined at https://github.com/hashicorp/terraform-provider-aws/blob/master/docs/contributing/contribution-checklists.md#new-resource), this should be called aws_codeguruprofiler_profiling_group.

@taylora433
Copy link
Author

Thank you for the response. I'll update the naming :)

@adeline-chew-sp
Copy link

adeline-chew-sp commented May 11, 2021

Hi there, is there any plan in getting this implemented?

@dwilches
Copy link

dwilches commented Aug 6, 2021

Any news on the state of this request?

@marcelo-herrera-sp
Copy link

Anything new on this request?

@0x91
Copy link
Contributor

0x91 commented May 16, 2022

bump?

@weallwegot
Copy link

checking in on this- any alternative to setting up profiling on AWS with terraform?

@breathingdust breathingdust added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 24, 2023
chlunde added a commit to chlunde/terraform-provider-aws that referenced this issue Nov 10, 2023
@johnsonaj johnsonaj self-assigned this Nov 29, 2023
@github-actions github-actions bot added this to the v5.30.0 milestone Dec 1, 2023
Copy link

github-actions bot commented Dec 7, 2023

This functionality has been released in v5.30.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jan 7, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/codeguruprofiler Issues and PRs that pertain to the codeguruprofiler service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants