New Resource: aws_route53_key_signing_key

[bflad]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Requires #16834
Reference: #16836

Release note for CHANGELOG:

* **New Resource:** `aws_route53_key_signing_key`

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAwsRoute53KeySigningKey_disappears (209.62s)
--- PASS: TestAccAwsRoute53KeySigningKey_basic (233.38s)
--- PASS: TestAccAwsRoute53KeySigningKey_Status (295.66s)

[YakDriver]

In GovCloud, all these tests should skip but, when run parallel, 2 out of 3 consistently fail.

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run='TestAccAwsRoute53KeySigningKey_' -timeout 120m
    route53_key_signing_key_test.go:45: Route 53 Key Signing Key not available in this AWS Partition
--- SKIP: TestAccAwsRoute53KeySigningKey_basic (1.12s)
=== CONT  TestAccAwsRoute53KeySigningKey_Status
    resource_aws_route53_key_signing_key_test.go:84: Step 1/4 error: Error running pre-apply refresh: 
        Error: Invalid AWS Region: 
=== CONT  TestAccAwsRoute53KeySigningKey_disappears
    resource_aws_route53_key_signing_key_test.go:62: Step 1/1 error: Error running pre-apply refresh: 
        Error: Invalid AWS Region: 
--- FAIL: TestAccAwsRoute53KeySigningKey_disappears (2.13s)
--- FAIL: TestAccAwsRoute53KeySigningKey_Status (2.14s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	3.201s

[YakDriver]

I wonder if we shouldn't pull this over into the ParallelTest() anonymous PreCheck function. If later we add a testAccPartitionHasServicePreCheck linter, this would fail even though it shouldn't.

[bflad]

@YakDriver fixed in latest commit to perform region lookup skipping outside sync.Once -- will probably need to apply this same change in other similar "special provider" test files as well, but will do that separately.

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAwsRoute53KeySigningKey_disappears (157.73s)
--- PASS: TestAccAwsRoute53KeySigningKey_basic (180.64s)
--- PASS: TestAccAwsRoute53KeySigningKey_Status (218.81s)

Output from acceptance testing in AWS GovCloud (US):

=== CONT  TestAccAwsRoute53KeySigningKey_basic
    route53_key_signing_key_test.go:40: Route 53 Key Signing Key not available in this AWS Partition
--- SKIP: TestAccAwsRoute53KeySigningKey_basic (2.52s)
=== CONT  TestAccAwsRoute53KeySigningKey_Status
    route53_key_signing_key_test.go:40: Route 53 Key Signing Key not available in this AWS Partition
=== CONT  TestAccAwsRoute53KeySigningKey_disappears
    route53_key_signing_key_test.go:40: Route 53 Key Signing Key not available in this AWS Partition
--- SKIP: TestAccAwsRoute53KeySigningKey_Status (2.52s)
--- SKIP: TestAccAwsRoute53KeySigningKey_disappears (2.52s)

[YakDriver]

Looks good!

GovCloud:

--- SKIP: TestAccAwsRoute53KeySigningKey_basic (1.21s)
--- SKIP: TestAccAwsRoute53KeySigningKey_Status (1.21s)
--- SKIP: TestAccAwsRoute53KeySigningKey_disappears (1.21s)

us-west-2:

--- PASS: TestAccAwsRoute53KeySigningKey_disappears (134.30s)
--- PASS: TestAccAwsRoute53KeySigningKey_basic (136.01s)
--- PASS: TestAccAwsRoute53KeySigningKey_Status (182.55s)

[ghost]

This has been released in version 3.27.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!