resource/aws_service_discovery_instance: new implementation

[dirk39]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #8568

The output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSServiceDiscoveryInstance'

...

This is the implementation of the APIs to Register/Deregister instances into the AWS CloudMap service. Link to the doc here

[github-actions]

Welcome @dirk39 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[alexanderj1988]

exactly what we need, too!!!

[ghost]

Any chance this can be merged?

[JeromeErasmus]

can we get this merged?

[denzhel]

Any chance this will get merged ?

[barakharyati]

Hi, any updates about that PR ?

[ghost]

any reason not to push the button? Seems like someone has done quite some work to get this far and it would be a shame to let that effort go to waste - plus I could really use this feature that was inexplicably left out in the first place

[cageyv]

This resource also helps to solve this problem with AWS App Mesh
"Your application is unable to resolve the DNS name of a virtual service that it is attempting to connect to."
https://docs.aws.amazon.com/app-mesh/latest/userguide/troubleshoot-connectivity.html#ts-connectivity-dns-resolution-virtual-service

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSServiceDiscoveryInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceDiscoveryInstance_ -timeout 180m
=== RUN   TestAccAWSServiceDiscoveryInstance_private
=== PAUSE TestAccAWSServiceDiscoveryInstance_private
=== RUN   TestAccAWSServiceDiscoveryInstance_public
=== PAUSE TestAccAWSServiceDiscoveryInstance_public
=== RUN   TestAccAWSServiceDiscoveryInstance_http
=== PAUSE TestAccAWSServiceDiscoveryInstance_http
=== CONT  TestAccAWSServiceDiscoveryInstance_private
=== CONT  TestAccAWSServiceDiscoveryInstance_http
=== CONT  TestAccAWSServiceDiscoveryInstance_public
--- PASS: TestAccAWSServiceDiscoveryInstance_public (139.99s)
--- PASS: TestAccAWSServiceDiscoveryInstance_private (163.20s)
--- PASS: TestAccAWSServiceDiscoveryInstance_http (163.49s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	166.883s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSServiceDiscoveryInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceDiscoveryInstance_ -timeout 180m
=== RUN   TestAccAWSServiceDiscoveryInstance_private
=== PAUSE TestAccAWSServiceDiscoveryInstance_private
=== RUN   TestAccAWSServiceDiscoveryInstance_public
=== PAUSE TestAccAWSServiceDiscoveryInstance_public
=== RUN   TestAccAWSServiceDiscoveryInstance_http
=== PAUSE TestAccAWSServiceDiscoveryInstance_http
=== CONT  TestAccAWSServiceDiscoveryInstance_private
=== CONT  TestAccAWSServiceDiscoveryInstance_http
=== CONT  TestAccAWSServiceDiscoveryInstance_public
=== CONT  TestAccAWSServiceDiscoveryInstance_private
    provider_test.go:735: skipping tests; partition aws-us-gov does not support servicediscovery service
=== CONT  TestAccAWSServiceDiscoveryInstance_http
    provider_test.go:735: skipping tests; partition aws-us-gov does not support servicediscovery service
=== CONT  TestAccAWSServiceDiscoveryInstance_public
    provider_test.go:735: skipping tests; partition aws-us-gov does not support servicediscovery service
--- SKIP: TestAccAWSServiceDiscoveryInstance_public (1.34s)
--- SKIP: TestAccAWSServiceDiscoveryInstance_private (1.34s)
--- SKIP: TestAccAWSServiceDiscoveryInstance_http (1.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.889s

[github-actions]

This functionality has been released in v3.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.