Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for access token and ID token validity to aws_cognito_user_pool_client #17979

Closed
ghost opened this issue Mar 8, 2021 · 2 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope.

Comments

@ghost
Copy link

ghost commented Mar 8, 2021

This issue was originally opened by @AlexWang-16 as hashicorp/terraform#28010. It was migrated here as a result of the provider split. The original body of the issue is below.


Current Terraform Version

Terraform v0.14.6
+ provider registry.terraform.io/hashicorp/archive v2.1.0
+ provider registry.terraform.io/hashicorp/aws v3.30.0
+ provider registry.terraform.io/hashicorp/random v3.1.0
+ provider registry.terraform.io/hashicorp/template v2.2.0
+ provider registry.terraform.io/hashicorp/vault v2.18.0

Use-cases

I want to be able to have Terraform manage the cognito user pool client access token and ID token validity period. Currently it only supports refresh token validity. Specifically, I want to be able to specify the number of days and minutes the tokens should be valid for. This is in line with the inputs AWS accepts via the Cognito console.

Attempted Solutions

I tried to specify access_token_validity and id_token_validity but those parameters did not exist. I also tried to do a terraform plan after manually modifying the settings in AWS console in hopes Terraform Plan would show me how those settings are set, but it does not show those values.

Proposal

I would like to include 2 parameters to aws_cognito_user_pool resource

  • access_token_validity
  • id_token_validity

The values should be expressed in seconds instead of days such that it can be converted appropriately into minutes and hours.
Alternatively, the value can be expressed as a map with "days" and "minutes" as keys and the corresponding values as numbers.

@ghost ghost added enhancement Requests to existing resources that expand the functionality or scope. new labels Mar 8, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 8, 2021
@DrFaust92
Copy link
Collaborator

Duplicate of #14919

@DrFaust92 DrFaust92 marked this as a duplicate of #14919 Mar 8, 2021
@ghost
Copy link
Author

ghost commented Apr 7, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 7, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

No branches or pull requests

2 participants