Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDB Replica - kms_key_arn support #18373

Merged
merged 35 commits into from Apr 13, 2021

Conversation

pmnathan
Copy link
Contributor

@pmnathan pmnathan commented Mar 24, 2021

Added optional attribute to replica that will enable an CMK ARN to be provided, this maps to the attribute available in the AWS Go SDK.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16358
Closes #18277

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDynamoDbTable_Replica_Single'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDynamoDbTable_Replica_Single -timeout 180m
=== RUN   TestAccAWSDynamoDbTable_Replica_Single
=== PAUSE TestAccAWSDynamoDbTable_Replica_Single
=== CONT  TestAccAWSDynamoDbTable_Replica_Single
--- PASS: TestAccAWSDynamoDbTable_Replica_Single (605.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	608.580s
...

@pmnathan pmnathan requested a review from a team as a code owner March 24, 2021 14:12
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/dynamodb Issues and PRs that pertain to the dynamodb service. labels Mar 24, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 24, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @pmnathan 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@YakDriver YakDriver self-assigned this Apr 12, 2021
@YakDriver YakDriver removed the needs-triage Waiting for first response or review from a maintainer. label Apr 12, 2021
@ghost ghost added size/L Managed by automation to categorize the size of a PR. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XXL Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. size/L Managed by automation to categorize the size of a PR. size/XL Managed by automation to categorize the size of a PR. labels Apr 12, 2021
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

Acceptance tests on commercial/standard (us-west-2):

--- PASS: TestAccDataSourceAwsDynamoDbTable_basic (35.38s)

--- PASS: TestAccAWSDynamoDbTable_streamSpecificationValidation (4.76s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdateValidation (10.19s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_enabled (29.29s)
--- PASS: TestAccAWSDynamoDbTable_basic (32.91s)
--- PASS: TestAccAWSDynamoDbTable_tags (43.97s)
--- PASS: TestAccAWSDynamoDbTable_lsiNonKeyAttributes (44.07s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_disabled (44.84s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_payPerRequestToProvisioned (40.21s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateCapacity (58.62s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes_emptyPlan (59.50s)
--- PASS: TestAccAWSDynamoDbTable_lsiUpdate (62.11s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_payPerRequestToProvisioned (63.11s)
--- PASS: TestAccAWSDynamoDbTable_enablePitr (63.74s)
--- PASS: TestAccAWSDynamoDbTable_disappears (20.21s)
--- PASS: TestAccAWSDynamoDbTable_streamSpecification (68.17s)
--- PASS: TestAccAWSDynamoDbTable_disappears_payPerRequestWithGSI (63.61s)
--- PASS: TestAccAWSDynamoDbTable_encryption (150.74s)
--- PASS: TestAccAWSDynamoDbTable_Replica_singleWithCMK (237.46s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes (266.77s)
--- PASS: TestAccAWSDynamoDbTable_extended (234.47s)
--- PASS: TestAccAWSDynamoDbTable_Replica_single (386.22s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdate (604.51s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes (606.57s)
--- PASS: TestAccAWSDynamoDbTable_Replica_multiple (734.54s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_provisionedToPayPerRequest (1020.42s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_provisionedToPayPerRequest (1320.11s)

Acceptance tests on GovCloud:

--- PASS: TestAccDataSourceAwsDynamoDbTable_basic (39.24s)

--- PASS: TestAccAWSDynamoDbTable_streamSpecificationValidation (6.58s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdateValidation (12.13s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_enabled (36.01s)
--- PASS: TestAccAWSDynamoDbTable_basic (37.84s)
--- PASS: TestAccAWSDynamoDbTable_tags (39.15s)
--- PASS: TestAccAWSDynamoDbTable_lsiNonKeyAttributes (39.98s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_disabled (52.64s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_payPerRequestToProvisioned (58.13s)
--- PASS: TestAccAWSDynamoDbTable_disappears (20.95s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes_emptyPlan (53.86s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateCapacity (65.49s)
--- PASS: TestAccAWSDynamoDbTable_lsiUpdate (72.22s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_payPerRequestToProvisioned (73.30s)
--- PASS: TestAccAWSDynamoDbTable_enablePitr (78.88s)
--- PASS: TestAccAWSDynamoDbTable_streamSpecification (79.04s)
--- PASS: TestAccAWSDynamoDbTable_disappears_payPerRequestWithGSI (69.28s)
--- PASS: TestAccAWSDynamoDbTable_encryption (126.93s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_provisionedToPayPerRequest (265.61s)
--- PASS: TestAccAWSDynamoDbTable_extended (257.47s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes (232.91s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_provisionedToPayPerRequest (277.64s)
--- PASS: TestAccAWSDynamoDbTable_Replica_singleWithCMK (323.35s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes (571.56s)
--- PASS: TestAccAWSDynamoDbTable_Replica_single (572.46s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdate (576.75s)

@YakDriver YakDriver added this to the v3.37.0 milestone Apr 13, 2021
@YakDriver YakDriver merged commit a78598a into hashicorp:main Apr 13, 2021
@ghost
Copy link

ghost commented Apr 16, 2021

This has been released in version 3.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 13, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/dynamodb Issues and PRs that pertain to the dynamodb service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to pass custom managed key in replicas of dynamodb global table v2
3 participants