Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: r/ssm_parameter description and allowed_pattern validation #18588

Conversation

cartucciam
Copy link
Contributor

@cartucciam cartucciam commented Apr 6, 2021

Closes #18552

description and allowed_pattern should allow minimum of 0 (aws documentation).

This change was introduced in #17830 and there are few issues linked to it.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccAWSSSMParameter_basic (151.37s)
--- PASS: TestAccAWSSSMParameter_fullPath (162.13s)
--- PASS: TestAccAWSSSMParameter_disappears (221.95s)
--- PASS: TestAccAWSSSMParameter_secure (293.26s)
--- PASS: TestAccAWSSSMParameter_DataType_AwsEc2Image (297.27s)
--- PASS: TestAccAWSSSMParameter_secure_with_key (300.38s)
--- PASS: TestAccAWSSSMParameter_updateDescription (394.64s)
--- PASS: TestAccAWSSSMParameter_changeNameForcesNew (395.52s)
--- PASS: TestAccAWSSSMParameter_updateType (397.82s)
--- PASS: TestAccAWSSSMParameter_overwrite (400.52s)
--- PASS: TestAccAWSSSMParameter_secure_keyUpdate (404.50s)
--- PASS: TestAccAWSSSMParameter_Tier (453.47s)
--- PASS: TestAccAWSSSMParameter_tags (455.93s)
--- PASS: TestAccAWSSSMParameter_Tier_IntelligentTieringToStandard (470.81s)
--- PASS: TestAccAWSSSMParameter_Tier_IntelligentTieringToAdvanced (472.78s)

@cartucciam cartucciam requested a review from a team as a code owner April 6, 2021 13:38
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ssm Issues and PRs that pertain to the ssm service. labels Apr 6, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 6, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @cartucciam 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@anGie44 anGie44 self-assigned this Apr 6, 2021
@anGie44 anGie44 added regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 6, 2021
@anGie44 anGie44 added this to the v3.36.0 milestone Apr 6, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @cartucciam , thank you for this fix 🚀 🚀

@anGie44
Copy link
Contributor

anGie44 commented Apr 6, 2021

Output of acceptance test in Commerical:

--- PASS: TestAccAWSSSMParameter_disappears (110.73s)
--- PASS: TestAccAWSSSMParameter_secure (184.88s)
--- PASS: TestAccAWSSSMParameter_basic (196.84s)
--- PASS: TestAccAWSSSMParameter_fullPath (260.12s)
--- PASS: TestAccAWSSSMParameter_secure_with_key (274.22s)
--- PASS: TestAccAWSSSMParameter_DataType_AwsEc2Image (294.50s)
--- PASS: TestAccAWSSSMParameter_updateDescription (316.83s)
--- PASS: TestAccAWSSSMParameter_updateType (328.26s)
--- PASS: TestAccAWSSSMParameter_overwrite (328.28s)
--- PASS: TestAccAWSSSMParameter_changeNameForcesNew (329.26s)
--- PASS: TestAccAWSSSMParameter_secure_keyUpdate (352.16s)
--- PASS: TestAccAWSSSMParameter_Tier_IntelligentTieringToStandard (363.78s)
--- PASS: TestAccAWSSSMParameter_Tier (364.65s)
--- PASS: TestAccAWSSSMParameter_Tier_IntelligentTieringToAdvanced (376.69s)
--- PASS: TestAccAWSSSMParameter_tags (377.35s)

@anGie44 anGie44 merged commit d150b41 into hashicorp:main Apr 6, 2021
@cartucciam cartucciam deleted the b_resource_aws_ssm_parameter_validation_for_description_and_allowed_pattern branch April 6, 2021 15:39
@ghost
Copy link

ghost commented Apr 9, 2021

This has been released in version 3.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 6, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/ssm Issues and PRs that pertain to the ssm service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allowed_pattern could not be 0 symbols hence omitted
2 participants